Ci 2 by marcofranssen · Pull Request #49 · notaryproject/notation

marcofranssen · 2021-04-06T12:22:33Z

See here the result of a workflow run: https://github.com/marcofranssen/nv2/runs/2278998738?check_suite_focus=true

SteveLasker · 2021-04-06T23:43:11Z

Thanks @marcofranssen, there's a bunch of great cleanup items here, such as the individual vscode settings, .gitignore entries and extensions.

@aviral26, @shizhMSFT can we merge this in, to cleanup things?

shizhMSFT · 2021-04-14T03:59:36Z

@marcofranssen Thanks for the PR.

Can you remove the settings in .vscode since developers may have their own configurations?

go.mod

Makefile

.github/workflows/golang.yml

.editorconfig

.gitignore

.vscode/extensions.json

Makefile

tools.go

go.mod

tools.go

Signed-off-by: Marco Franssen <marco.franssen@gmail.com>

Since go 1.16 some ioutil functions are deprecated and moved into the io package. Therefore can't build with previous versions of Go anymore Signed-off-by: Marco Franssen <marco.franssen@gmail.com>

Signed-off-by: Marco Franssen <marco.franssen@gmail.com>

shizhMSFT

LGTM

* Add basic workflow that compiles the binary Signed-off-by: Marco Franssen <marco.franssen@gmail.com> * Add dependabot for Go dependencies Signed-off-by: Marco Franssen <marco.franssen@gmail.com> * Add dependabot for github-actions Signed-off-by: Marco Franssen <marco.franssen@gmail.com> * Update workflow to use Makefile Signed-off-by: Marco Franssen <marco.franssen@gmail.com> * Include .editorconfig compatible with go fmt Signed-off-by: Marco Franssen <marco.franssen@gmail.com> * Run CI on go 1.16 Since go 1.16 some ioutil functions are deprecated and moved into the io package. Therefore can't build with previous versions of Go anymore Signed-off-by: Marco Franssen <marco.franssen@gmail.com> * Add help task to Makefile Signed-off-by: Marco Franssen <marco.franssen@gmail.com> * Add CI status badge Signed-off-by: Marco Franssen <marco.franssen@gmail.com>

* Initial prototype * Distribution api proposal * Formating fix * JWT based system (#16) * Fix paging api link * Resolve spelling errors * Fix examples to include full descriptor * Use library implementation * refactor network transport * add makefile * update dependency * push signature support * pull signature support * integrate sign and push * no output on sign-then-push by default * better ux for signature info * make install better * update notary library * update dependencies * Multiple signatures support (#52) * pull signatures when pulling images (#54) * Explicit add original references when signing (#57) * create parent folders before create config file (#59) * Add git clone steps to building.md * Ci 2 (#49) * Add basic workflow that compiles the binary * Add dependabot for Go dependencies * Add dependabot for github-actions * Update workflow to use Makefile * extract `list` from `pull --peek` * rename digest to sigDigests for code readability * update doc for building * refine doc for building * plain http in config * no default trust on generated cert * clean up media type * refine docker-notation * cached pull * refactor notation code * fix reference print * refactor docker-notation code * compare registry host case insensitively * refine docker-notation pull output * safer prune * prepare for v0.5.2 release * update notation-go-lib dependency * update release for go releaser * update notation-go-lib dependency * make github workflow consistent * output stderr for docker-generate * move implementations to the correct package * Include .editorconfig compatible with go fmt * Run CI on go 1.16 * Since go 1.16 some ioutil functions are deprecated and moved into the io package. Therefore can't build with previous versions of Go anymore * Add help task to Makefile * Add CI status badge * Notation CLI Alpha * bump notation-go-lib * prepare for 0.5.1 release * refine notation sign * Bump actions/cache from 2.1.4 to 2.1.6 * Bumps [actions/cache](https://github.com/actions/cache) from 2.1.4 to 2.1.6. * [Release notes](https://github.com/actions/cache/releases) * [Commits](actions/cache@v2.1.4...v2.1.6) This is a joint commit of - Shiwei Zhang - Aviral Takkar - Sajay Antony - Steve Lasker - Marco Franssen Signed-off-by: Steve Lasker <stevenlasker@hotmail.com> Signed-off-by: Shiwei Zhang <shizh@microsoft.com> Signed-off-by: Marco Franssen <marco.franssen@gmail.com>

* Initial prototype * Distribution api proposal * Formating fix * JWT based system (notaryproject#16) * Fix paging api link * Resolve spelling errors * Fix examples to include full descriptor * Use library implementation * refactor network transport * add makefile * update dependency * push signature support * pull signature support * integrate sign and push * no output on sign-then-push by default * better ux for signature info * make install better * update notary library * update dependencies * Multiple signatures support (notaryproject#52) * pull signatures when pulling images (notaryproject#54) * Explicit add original references when signing (notaryproject#57) * create parent folders before create config file (notaryproject#59) * Add git clone steps to building.md * Ci 2 (notaryproject#49) * Add basic workflow that compiles the binary * Add dependabot for Go dependencies * Add dependabot for github-actions * Update workflow to use Makefile * extract `list` from `pull --peek` * rename digest to sigDigests for code readability * update doc for building * refine doc for building * plain http in config * no default trust on generated cert * clean up media type * refine docker-notation * cached pull * refactor notation code * fix reference print * refactor docker-notation code * compare registry host case insensitively * refine docker-notation pull output * safer prune * prepare for v0.5.2 release * update notation-go-lib dependency * update release for go releaser * update notation-go-lib dependency * make github workflow consistent * output stderr for docker-generate * move implementations to the correct package * Include .editorconfig compatible with go fmt * Run CI on go 1.16 * Since go 1.16 some ioutil functions are deprecated and moved into the io package. Therefore can't build with previous versions of Go anymore * Add help task to Makefile * Add CI status badge * Notation CLI Alpha * bump notation-go-lib * prepare for 0.5.1 release * refine notation sign * Bump actions/cache from 2.1.4 to 2.1.6 * Bumps [actions/cache](https://github.com/actions/cache) from 2.1.4 to 2.1.6. * [Release notes](https://github.com/actions/cache/releases) * [Commits](actions/cache@v2.1.4...v2.1.6) This is a joint commit of - Shiwei Zhang - Aviral Takkar - Sajay Antony - Steve Lasker - Marco Franssen Signed-off-by: Steve Lasker <stevenlasker@hotmail.com> Signed-off-by: Shiwei Zhang <shizh@microsoft.com> Signed-off-by: Marco Franssen <marco.franssen@gmail.com>

marcofranssen force-pushed the ci-2 branch 4 times, most recently from eb87d9b to 4473f66 Compare April 6, 2021 12:36

marcofranssen mentioned this pull request Apr 6, 2021

Ci #24

Closed

marcofranssen force-pushed the ci-2 branch 3 times, most recently from ff890da to 648ff8e Compare April 6, 2021 12:48

shizhMSFT reviewed Apr 14, 2021

View reviewed changes

go.mod Outdated Show resolved Hide resolved

Makefile Outdated Show resolved Hide resolved

marcofranssen force-pushed the ci-2 branch from c53a2b9 to 7dfca31 Compare April 14, 2021 12:38

shizhMSFT requested changes Apr 15, 2021

View reviewed changes

marcofranssen force-pushed the ci-2 branch 5 times, most recently from 5aaccbb to 2d11f1a Compare April 21, 2021 12:47

marcofranssen force-pushed the ci-2 branch from 45cad64 to 3a3082d Compare April 28, 2021 10:05

marcofranssen added 8 commits May 6, 2021 20:35

Add basic workflow that compiles the binary

f05ca69

Signed-off-by: Marco Franssen <marco.franssen@gmail.com>

Add dependabot for Go dependencies

38b6f59

Signed-off-by: Marco Franssen <marco.franssen@gmail.com>

Add dependabot for github-actions

a138d27

Signed-off-by: Marco Franssen <marco.franssen@gmail.com>

Update workflow to use Makefile

09c6bd2

Signed-off-by: Marco Franssen <marco.franssen@gmail.com>

Include .editorconfig compatible with go fmt

422f565

Signed-off-by: Marco Franssen <marco.franssen@gmail.com>

Run CI on go 1.16

eaddf26

Since go 1.16 some ioutil functions are deprecated and moved into the io package. Therefore can't build with previous versions of Go anymore Signed-off-by: Marco Franssen <marco.franssen@gmail.com>

Add help task to Makefile

559ad84

Signed-off-by: Marco Franssen <marco.franssen@gmail.com>

Add CI status badge

03c7910

Signed-off-by: Marco Franssen <marco.franssen@gmail.com>

marcofranssen force-pushed the ci-2 branch from 3a3082d to 03c7910 Compare May 6, 2021 18:38

shizhMSFT approved these changes May 8, 2021

View reviewed changes

shizhMSFT merged commit 31ebf20 into notaryproject:prototype-2 May 8, 2021

marcofranssen deleted the ci-2 branch May 10, 2021 06:58

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Comments

Ci 2#49

Ci 2#49
shizhMSFT merged 8 commits intonotaryproject:prototype-2from
marcofranssen:ci-2

marcofranssen commented Apr 6, 2021 •

edited

Loading

Uh oh!

SteveLasker commented Apr 6, 2021

Uh oh!

shizhMSFT commented Apr 14, 2021

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

shizhMSFT left a comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Comments

Conversation

marcofranssen commented Apr 6, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

SteveLasker commented Apr 6, 2021

Uh oh!

shizhMSFT commented Apr 14, 2021

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

shizhMSFT left a comment

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

marcofranssen commented Apr 6, 2021 •

edited

Loading