Skip to content

Comments

Explicit add original references when signing#57

Merged
SteveLasker merged 1 commit intonotaryproject:prototype-2from
shizhMSFT:sign_ref
Apr 26, 2021
Merged

Explicit add original references when signing#57
SteveLasker merged 1 commit intonotaryproject:prototype-2from
shizhMSFT:sign_ref

Conversation

@shizhMSFT
Copy link
Contributor

Resolves #56

Signed-off-by: Shiwei Zhang <shizh@microsoft.com>
Copy link
Contributor

@SteveLasker SteveLasker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@SteveLasker SteveLasker merged commit 3066968 into notaryproject:prototype-2 Apr 26, 2021
@shizhMSFT shizhMSFT deleted the sign_ref branch April 27, 2021 02:47
shizhMSFT referenced this pull request in shizhMSFT/notation Sep 3, 2021
Signed-off-by: Shiwei Zhang <shizh@microsoft.com>
shizhMSFT referenced this pull request in shizhMSFT/notation Sep 10, 2021
Signed-off-by: Shiwei Zhang <shizh@microsoft.com>
SteveLasker pushed a commit that referenced this pull request Sep 16, 2021
* Initial prototype
* Distribution api proposal
* Formating fix
* JWT based system (#16)
* Fix paging api link
* Resolve spelling errors
* Fix examples to include full descriptor
* Use library implementation
* refactor network transport
* add makefile
* update dependency
* push signature support
* pull signature support
* integrate sign and push
* no output on sign-then-push by default
* better ux for signature info
* make install better
* update notary library
* update dependencies
* Multiple signatures support (#52)
* pull signatures when pulling images (#54)
* Explicit add original references when signing (#57)
* create parent folders before create config file (#59)
* Add git clone steps to building.md
* Ci 2 (#49)
* Add basic workflow that compiles the binary
* Add dependabot for Go dependencies
* Add dependabot for github-actions
* Update workflow to use Makefile
* extract `list` from `pull --peek`
* rename digest to sigDigests for code readability
* update doc for building
* refine doc for building
* plain http in config
* no default trust on generated cert
* clean up media type
* refine docker-notation
* cached pull
* refactor notation code
* fix reference print
* refactor docker-notation code
* compare registry host case insensitively
* refine docker-notation pull output
* safer prune
* prepare for v0.5.2 release
* update notation-go-lib dependency
* update release for go releaser
* update notation-go-lib dependency
* make github workflow consistent
* output stderr for docker-generate
* move implementations to the correct package
* Include .editorconfig compatible with go fmt
* Run CI on go 1.16
* Since go 1.16 some ioutil functions are deprecated and moved into the io package. Therefore can't build with previous versions of Go anymore
* Add help task to Makefile
* Add CI status badge
* Notation CLI Alpha
* bump notation-go-lib
* prepare for 0.5.1 release
* refine notation sign
* Bump actions/cache from 2.1.4 to 2.1.6
* Bumps [actions/cache](https://github.com/actions/cache) from 2.1.4 to 2.1.6.
* [Release notes](https://github.com/actions/cache/releases)
* [Commits](actions/cache@v2.1.4...v2.1.6)

This is a joint commit of
- Shiwei Zhang
- Aviral Takkar
- Sajay Antony
- Steve Lasker
- Marco Franssen


Signed-off-by: Steve Lasker <stevenlasker@hotmail.com>
Signed-off-by: Shiwei Zhang <shizh@microsoft.com>
Signed-off-by: Marco Franssen <marco.franssen@gmail.com>
7h3-3mp7y-m4n pushed a commit to 7h3-3mp7y-m4n/notation that referenced this pull request Mar 29, 2025
* Initial prototype
* Distribution api proposal
* Formating fix
* JWT based system (notaryproject#16)
* Fix paging api link
* Resolve spelling errors
* Fix examples to include full descriptor
* Use library implementation
* refactor network transport
* add makefile
* update dependency
* push signature support
* pull signature support
* integrate sign and push
* no output on sign-then-push by default
* better ux for signature info
* make install better
* update notary library
* update dependencies
* Multiple signatures support (notaryproject#52)
* pull signatures when pulling images (notaryproject#54)
* Explicit add original references when signing (notaryproject#57)
* create parent folders before create config file (notaryproject#59)
* Add git clone steps to building.md
* Ci 2 (notaryproject#49)
* Add basic workflow that compiles the binary
* Add dependabot for Go dependencies
* Add dependabot for github-actions
* Update workflow to use Makefile
* extract `list` from `pull --peek`
* rename digest to sigDigests for code readability
* update doc for building
* refine doc for building
* plain http in config
* no default trust on generated cert
* clean up media type
* refine docker-notation
* cached pull
* refactor notation code
* fix reference print
* refactor docker-notation code
* compare registry host case insensitively
* refine docker-notation pull output
* safer prune
* prepare for v0.5.2 release
* update notation-go-lib dependency
* update release for go releaser
* update notation-go-lib dependency
* make github workflow consistent
* output stderr for docker-generate
* move implementations to the correct package
* Include .editorconfig compatible with go fmt
* Run CI on go 1.16
* Since go 1.16 some ioutil functions are deprecated and moved into the io package. Therefore can't build with previous versions of Go anymore
* Add help task to Makefile
* Add CI status badge
* Notation CLI Alpha
* bump notation-go-lib
* prepare for 0.5.1 release
* refine notation sign
* Bump actions/cache from 2.1.4 to 2.1.6
* Bumps [actions/cache](https://github.com/actions/cache) from 2.1.4 to 2.1.6.
* [Release notes](https://github.com/actions/cache/releases)
* [Commits](actions/cache@v2.1.4...v2.1.6)

This is a joint commit of
- Shiwei Zhang
- Aviral Takkar
- Sajay Antony
- Steve Lasker
- Marco Franssen


Signed-off-by: Steve Lasker <stevenlasker@hotmail.com>
Signed-off-by: Shiwei Zhang <shizh@microsoft.com>
Signed-off-by: Marco Franssen <marco.franssen@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

nv2 sign & validate shouldn't require cn = registry name

2 participants