Skip to content

Add GOVERNANCE.md#78

Closed
lachie83 wants to merge 3 commits intonotaryproject:mainfrom
lachie83:add-governance
Closed

Add GOVERNANCE.md#78
lachie83 wants to merge 3 commits intonotaryproject:mainfrom
lachie83:add-governance

Conversation

@lachie83
Copy link
Copy Markdown
Contributor

Outline project governance as discussed at the community meeting Friday, June 25

Fixes: #77

cc @SteveLasker @justincormack

Signed-off-by: Lachlan Evenson lachlan.evenson@microsoft.com

Signed-off-by: Lachlan Evenson <lachlan.evenson@microsoft.com>
Comment thread GOVERNANCE.md Outdated
Signed-off-by: Lachlan Evenson <lachlan.evenson@microsoft.com>
Comment thread GOVERNANCE.md Outdated
vote of the existing maintainers. A potential maintainer may be nominated by an existing maintainer.
Submissions for new maintainers can be made by creating an
[issue](https://github.com/notaryproject/notaryproject/issues/new). The current maintainers will cast
their vote via a +1 comment on the issue. Once a [super-majority](https://en.wikipedia.org/wiki/Supermajority#Two-thirds_vote)
Copy link
Copy Markdown

@anvega anvega Jun 25, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The current maintainers will cast their vote via a +1 comment on the issue.

How many votes can be cast?

Also, If going off by the codeowners file being introduced as part of this PR, restricting voting to two individuals makes it that supermajority has to be the absolute majority. Worth considering extending the voting to all community members and contributors with demonstrated active engagement.

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How many votes can be cast?

A single vote per maintainer. (I will update)

Also, If going off by the codeowners file being introduced as part of this PR, restricting voting to two individuals makes it that supermajority has to be the absolute majority. Worth considering extending the voting to all community members and contributors with demonstrated active engagement.

It might be worth using the linked issue as a seed set of maintainers before putting this into effect so that we can establish a super-majority as noted. We may have to add some verbiage about how the seed maintainers will be selected also. I'll add this to the agenda for the next meeting.

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's also worth pointing out that the initial maintainers must show a track record of having been publicly actively involved in the project so far. I'm afraid that at least one of them has not.

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fair point - Do you of any other CNCF projects that have a maintainer definition outside of the spiffe project as I'm taking a look around to see if there is good precedence on maintainer requirements that this project might consider adopting. I also see https://github.com/openservicemesh/osm/blob/main/CONTRIBUTING_LADDER.md#maintainer

Copy link
Copy Markdown

@trishankatdatadog trishankatdatadog Jun 25, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The closest I can find so far is the TUF governance model. We have the equivalent of a "BDFL" who necessarily must remain active in order to remain one. Otherwise, maintainers and the community can initiate, vote for, and enact changes. So, the FL in BDFL is conditional on the community.

Add Governance to TOC

Signed-off-by: Lachlan Evenson <lachlan.evenson@microsoft.com>
Comment thread GOVERNANCE.md
vote of the existing maintainers. A potential maintainer may be nominated by an existing maintainer.
Submissions for new maintainers can be made by creating an
[issue](https://github.com/notaryproject/notaryproject/issues/new). The current maintainers will be able to cast
a single vote each via a +1 comment on the issue. Once a [super-majority](https://en.wikipedia.org/wiki/Supermajority#Two-thirds_vote)
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The current maintainers will be able to cast
a single vote each via a +1 comment on the issue.

Does this in practice mean that two votes in total (one by each current maintainer)? If so, both maintainers must cast their votes for the exact same nominee for there to be anyone elected. Or is it, each maintainer can vote just once for every nominee?

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The latter. This could change if we prefer the idea of having a fixed number of maintainer seats, then we could do a ranked voting across candidates.

@dlorenc
Copy link
Copy Markdown

dlorenc commented Jun 26, 2021

Another question - is the CODEOWNERS file here meant to represent the entire project (everything under notaryproject/*) or just this repo? Do we need to repeat this process for all the other repos?

@lachie83
Copy link
Copy Markdown
Contributor Author

Another question - is the CODEOWNERS file here meant to represent the entire project (everything under notaryproject/*) or just this repo? Do we need to repeat this process for all the other repos?

I would suggest that we repeat this process for all other repos as they could potentially have a different set of maintainers.

Comment thread CODEOWNERS
@@ -0,0 +1 @@
* @justincormack @SteveLasker
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
* @justincormack @SteveLasker
* @notaryproject

This will allow anyone part of this team to own the code.

@lachie83
Copy link
Copy Markdown
Contributor Author

Handed off this work to @justincormack via notaryproject/notary#1606. Closing this PR in favor of that one.

@lachie83 lachie83 closed this Aug 10, 2021
SteveLasker added a commit to SteveLasker/notaryproject that referenced this pull request Jul 8, 2022
Signed-off-by: Steve Lasker <stevenlasker@hotmail.com>
SteveLasker added a commit that referenced this pull request Jul 13, 2022
Signed-off-by: Steve Lasker <stevenlasker@hotmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Request for formal governance documentation and additional maintainers

6 participants