Simplify NpgsqlMigrationsSqlGenerator.Generate for CreateSequenceOperation#639
Merged
roji merged 1 commit intonpgsql:devfrom Sep 23, 2018
slavanap:simplify_generate
Merged
Simplify NpgsqlMigrationsSqlGenerator.Generate for CreateSequenceOperation#639roji merged 1 commit intonpgsql:devfrom slavanap:simplify_generate
roji merged 1 commit intonpgsql:devfrom
slavanap:simplify_generate
Conversation
roji
reviewed
Sep 18, 2018
| builder.AppendLine(_sqlGenerationHelper.StatementTerminator); | ||
| EndStatement(builder); | ||
| base.Generate(operation, model, builder); | ||
| operation.ClrType = oldValue; |
Member
There was a problem hiding this comment.
This is a bit far-fetched, but I'd rather we didn't set ClrType if we don't need to (i.e. when on PG 10.0 or above). In other words, if VersionAtLeast(10, 0) just call directly into base.Generate() and return. Otherwise looks good, thanks for the correction...
Contributor
Author
|
I've amended commit with the proposed fix. |
Member
|
Note - not backporting to 2.1 because we don't have the backwards compat support there. I think this is an OK situation, 2.2 isn't so far away in any case. |
Contributor
Author
|
Okay. Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Simple refactoring for #607
@roji, let's continue our discussion here