Skip to content

Simplify NpgsqlMigrationsSqlGenerator.Generate for CreateSequenceOperation #639

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
roji merged 1 commit into from
Sep 23, 2018
Merged

Simplify NpgsqlMigrationsSqlGenerator.Generate for CreateSequenceOperation #639

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
20 changes: 7 additions & 13 deletions src/EFCore.PG/Migrations/NpgsqlMigrationsSqlGenerator.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -923,27 +923,21 @@ protected override void Generate(
protected override void Generate(CreateSequenceOperation operation, IModel model, MigrationCommandListBuilder builder)
{
Check.NotNull(operation, nameof(operation));
Check.NotNull(builder, nameof(builder));

if (VersionAtLeast(10, 0))
{
base.Generate(operation, model, builder);
}
else
{
// "CREATE SEQUENCE name AS type" expression is supported only in PostgreSQL 10 or above.
// The base MigrationsSqlGenerator.Generate method generates that expression.
// https://github.com/aspnet/EntityFrameworkCore/blob/master/src/EFCore.Relational/Migrations/MigrationsSqlGenerator.cs#L533-L535
var oldValue = operation.ClrType;
operation.ClrType = typeof(long);
base.Generate(operation, model, builder);
return;
operation.ClrType = oldValue;
}

// Generate CREATE SEQUENCE without "AS" part.
builder
.Append("CREATE SEQUENCE ")
.Append(_sqlGenerationHelper.DelimitIdentifier(operation.Name, operation.Schema))
.Append(" START WITH ")
.Append(_typeMappingSource.GetMapping(typeof(long)).GenerateSqlLiteral(operation.StartValue));

SequenceOptions(operation, model, builder);
builder.AppendLine(_sqlGenerationHelper.StatementTerminator);
EndStatement(builder);
}

#endregion Standard migrations
Expand Down