Conversation
Contributor
Author
Release ManagerRelease workflow run: https://github.com/npm/node-semver/actions/runs/4723796619 Force CI to Update This ReleaseThis PR will be updated and CI will run for every non- Release Checklist for v7.5.0
|
b63430e to
51ed80f
Compare
a59742c to
75f39ef
Compare
Member
|
Double checking #547 and I see a problem where it would have thrown with a good warning, now it throws w/ an unexpected error
> semver.diff('foo', '1.2.3')
Uncaught TypeError: Invalid Version: nullnow > semver.diff('foo', '1.2.3')
Uncaught TypeError: Cannot read properties of null (reading 'compare')Need to fix this before releasing. #552 is the fix |
75f39ef to
c4186af
Compare
c4186af to
8a04062
Compare
wraithgar
approved these changes
Apr 17, 2023
Contributor
Author
Release Workflow |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🤖 I have created a release beep boop
7.5.0 (2023-04-17)
Features
503a4e5#548 allow identifierBase to be false (feat: allow identifierBase to be false #548) (@lsvalina)Bug Fixes
e219bb4#552 throw on bad version with correct error message (fix: throw on bad version with correct error message #552) (@wraithgar)fc2f3df#546 incorrect results from diff sometimes with prerelease versions (fix: incorrect results from diff sometimes with prerelease versions #546) (@tjenkinson)2781767#547 avoid re-instantiating SemVer during diff compare (fix: avoid re-instantiating SemVer during diff compare #547) (@macno)This PR was generated with Release Please. See documentation.