fix: throw on bad version with correct error message

[wraithgar]

The parsing logic that is duplicated in SemVer's constructor was also removed. See #541 for previous discussions about not optimizing for invalid SemVer.

With this fix:

> semver.diff('foo', '1.2.3')
Uncaught TypeError: Invalid Version: foo

v7.4.0:

> semver.diff('foo', '1.2.3')
Uncaught TypeError: Invalid Version: null

503a4e52:

> semver.diff('foo', '1.2.3')
Uncaught TypeError: Cannot read properties of null (reading 'compare')

[wraithgar]

This does reinstantiate, perhaps we need an unsafe parse (i.e. one that doesn't catch)

[wraithgar]

Arrays and objects still throw an ambiguous message but is it worth bringing in something like util.inspect?

> require('.').diff([], '1.3.2')
Uncaught TypeError: Invalid Version: 

> require('.').diff({}, '1.3.2')
Uncaught TypeError: Invalid Version: [object Object]

vs

throw new TypeError(`Invalid Version: ${require('util').inspect(version)}`)`

> require('.').diff([], '1.3.2')
Uncaught TypeError: Invalid Version: []

> require('.').diff({}, '1.3.2')
Uncaught TypeError: Invalid Version: {}

[tjenkinson]

Given that code path should only be hit if you're doing something really wrong, I don't see any harm in making the error more readable with inspect

[UNIDY2002]

I don't see any harm in making the error more readable with inspect

Oops... This does break something.

I am using this library in a react-native project, and since RN does not run in a Node.js environment, its bundler might not recognize the "util" module, causing bundle failure.

I've just received a failure report, and haven't investigated into it.

---

Update: I installed util for polyfill, and now it is working fine.

[tjenkinson]

Ah I checked the node version support of it but didn’t realise this was also used in a browser 🙈