Skip to content

Comments

chore: include new deps to vite optimized deps#1031

Merged
danielroe merged 1 commit intonpmx-dev:mainfrom
userquin:update-optimized-deps
Feb 5, 2026
Merged

chore: include new deps to vite optimized deps#1031
danielroe merged 1 commit intonpmx-dev:mainfrom
userquin:update-optimized-deps

Conversation

@userquin
Copy link
Member

@userquin userquin commented Feb 5, 2026

From time to time we add some dependencies that should be optimized, this PR adds the following dependencies:

  • @vueuse/integrations/useFocusTrap
  • fast-npm-meta
  • @floating-ui/vue
image

@vercel
Copy link

vercel bot commented Feb 5, 2026

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
npmx.dev Error Error Feb 5, 2026 6:24pm
2 Skipped Deployments
Project Deployment Actions Updated (UTC)
docs.npmx.dev Ignored Ignored Preview Feb 5, 2026 6:24pm
npmx-lunaria Ignored Ignored Feb 5, 2026 6:24pm

Request Review

@codecov
Copy link

codecov bot commented Feb 5, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ All tests successful. No failed tests found.

📢 Thoughts on this report? Let us know!

@coderabbitai
Copy link
Contributor

coderabbitai bot commented Feb 5, 2026

📝 Walkthrough

Walkthrough

The pull request modifies nuxt.config.ts to add three dependencies to the optimizeDeps.include configuration array. The additions are "@vueuse/integrations/useFocusTrap", "fast-npm-meta", and "@floating-ui/vue". These dependencies are now included in Nuxt's Vite optimisation step for pre-bundling during the build process. The change comprises three new lines with no deletions.

🚥 Pre-merge checks | ✅ 1
✅ Passed checks (1 passed)
Check name Status Explanation
Description check ✅ Passed The pull request description clearly describes the changeset, explicitly listing the three dependencies being added to Vite's optimized deps.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing touches
  • 📝 Generate docstrings
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment

Comment @coderabbitai help to get the list of available commands and usage tips.

Copy link
Contributor

@trueberryless trueberryless left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🎉

@danielroe danielroe added this pull request to the merge queue Feb 5, 2026
Merged via the queue into npmx-dev:main with commit fd89de3 Feb 5, 2026
16 of 17 checks passed
@userquin userquin deleted the update-optimized-deps branch February 5, 2026 20:59
@EDM115
Copy link

EDM115 commented Feb 6, 2026

@userquin (sorry for the ping) I always wondered, is there any guidelines out there that rules which deps should/shouldn't be optimized by Vite ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants