Skip to content

Comments

chore: add @vueuse/shared dependency#1176

Merged
danielroe merged 2 commits intonpmx-dev:mainfrom
userquin:chore-add-vueuse-share-dependency
Feb 7, 2026
Merged

chore: add @vueuse/shared dependency#1176
danielroe merged 2 commits intonpmx-dev:mainfrom
userquin:chore-add-vueuse-share-dependency

Conversation

@userquin
Copy link
Member

@userquin userquin commented Feb 7, 2026

There is no way to run local dev server on my Windows laptop without adding @vueuse/shared dependency.

This PR also adds '@vueuse/integrations/useFocusTrap/component' to vite optimized deps.

/cc @OrbisK

image

@codecov
Copy link

codecov bot commented Feb 7, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ All tests successful. No failed tests found.

📢 Thoughts on this report? Let us know!

@coderabbitai
Copy link
Contributor

coderabbitai bot commented Feb 7, 2026

📝 Walkthrough

Walkthrough

This pull request updates dependency handling and build pre-bundling. nuxt.config.ts adds '@vueuse/integrations/useFocusTrap/component' to Vite's optimizeDeps.include to pre-bundle the FocusTrap component integration. package.json adds a new dependency '@vueuse/shared' at version 14.2.0. knip.ts adds '@vueuse/shared' to ignoreDependencies. No exported APIs or control-flow logic were changed.

Possibly related PRs

Suggested reviewers

  • trueberryless
  • danielroe
🚥 Pre-merge checks | ✅ 1
✅ Passed checks (1 passed)
Check name Status Explanation
Description check ✅ Passed The pull request description clearly describes the changes: adding @vueuse/shared dependency for Windows laptop development and adding @vueuse/integrations/useFocusTrap/component to Vite optimised deps.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment

Comment @coderabbitai help to get the list of available commands and usage tips.

Copy link
Member

@danielroe danielroe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this sounds like a bug in vite but happy to add for you

@danielroe danielroe enabled auto-merge February 7, 2026 21:37
@danielroe danielroe disabled auto-merge February 7, 2026 21:45
@danielroe danielroe added this pull request to the merge queue Feb 7, 2026
Merged via the queue into npmx-dev:main with commit 3470512 Feb 7, 2026
16 checks passed
@userquin userquin deleted the chore-add-vueuse-share-dependency branch February 7, 2026 21:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants