test: avoid redundant html validation#1083
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
2 Skipped Deployments
|
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
📝 WalkthroughWalkthroughCI and a11y workflows were updated to use a new test-focused build step: Possibly related PRs
🚥 Pre-merge checks | ✅ 1✅ Passed checks (1 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing touches
🧪 Generate unit tests (beta)
Comment |
|
@OrbisK's suggestion is the native way to do this however, enabling this only in test mode will prevent it being added on prod deployments, but will also prevent it being loaded in development, where it's useful. and it will still run for both browser + a11y tests.... let me push a change. |
|
Yeah great, opt-in is even better. |
Currently the HTML validation via
@nuxtjs/html-validatorruns 4 times:If there is any html validation error, all 4 fail, making things look worse then they are.
This changes it so, that the validation is skipped for all 3 ci tests and only runs on Vercel.
This also removes the scriptbuild:playwright, because I don't think anyone will use that locally and it wasn't even used consequently in all tests.I think ideally the html validation shouldn't run on Vercel (so you still get a deploy preview), and run somewhere else (ci: "🖥️ Browser tests" or a separate test), but that would require to changing the Vercel build script.