Skip to content

test: avoid redundant html validation #1083

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
danielroe merged 4 commits into from
Feb 6, 2026
Merged

test: avoid redundant html validation #1083

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
06ef276
test: avoid redundant html validation
essenmitsosse Feb 6, 2026
eeb0010
fix: readd script
essenmitsosse Feb 6, 2026
5c50d7a
Merge remote-tracking branch 'origin/main' into avoid-redundant-html-…
danielroe Feb 6, 2026
197201c
refactor: enable only for browser tests
danielroe Feb 6, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 4 additions & 2 deletions .github/workflows/ci.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -150,7 +150,9 @@ jobs:
run: pnpm install

- name: 🏗️ Build project
run: pnpm build:playwright
run: pnpm build:test
env:
VALIDATE_HTML: true

- name: 🖥️ Test project (browser)
run: pnpm test:browser:prebuilt
Expand Down Expand Up @@ -178,7 +180,7 @@ jobs:
run: pnpm install

- name: 🏗️ Build project
run: NODE_ENV=test pnpm build
run: pnpm build:test

- name: ♿ Accessibility audit (Lighthouse - ${{ matrix.mode }} mode)
run: ./scripts/lighthouse-a11y.sh
Expand Down
2 changes: 2 additions & 0 deletions nuxt.config.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,6 @@
import process from 'node:process'
import { currentLocales } from './config/i18n'
import { isCI, provider } from 'std-env'

export default defineNuxtConfig({
modules: [
Expand Down Expand Up @@ -195,6 +196,7 @@ export default defineNuxtConfig({
},

htmlValidator: {
enabled: !isCI || (provider !== 'vercel' && !!process.env.VALIDATE_HTML),
failOnError: true,
},

Expand Down
8 changes: 4 additions & 4 deletions package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,7 @@
"scripts": {
"build": "nuxt build",
"build:lunaria": "node ./lunaria/lunaria.ts",
"build:playwright": "NODE_ENV=test pnpm build",
"build:test": "NODE_ENV=test pnpm build",
"dev": "nuxt dev",
"dev:docs": "pnpm run --filter npmx-docs dev --port=3001",
"i18n:check": "node scripts/compare-translations.ts",
Expand All @@ -30,10 +30,10 @@
"generate:fixtures": "node scripts/generate-fixtures.ts",
"generate:lexicons": "lex build --lexicons lexicons --out shared/types/lexicons --clear",
"test": "vite test",
"test:browser": "pnpm build:playwright && pnpm test:browser:prebuilt",
"test:browser": "pnpm build:test && pnpm test:browser:prebuilt",
"test:browser:prebuilt": "playwright test",
"test:browser:ui": "pnpm build:playwright && pnpm test:browser:prebuilt --ui",
"test:browser:update": "pnpm build:playwright && pnpm test:browser:prebuilt --update-snapshots",
"test:browser:ui": "pnpm build:test && pnpm test:browser:prebuilt --ui",
"test:browser:update": "pnpm build:test && pnpm test:browser:prebuilt --update-snapshots",
"test:nuxt": "vite test --project nuxt",
"test:types": "pnpm generate:lexicons && nuxt prepare && vue-tsc -b --noEmit && pnpm --filter npmx-connector test:types",
"test:unit": "vite test --project unit",
Expand Down
Loading