Skip to content

Comments

fix(ui): remove back button title on privacy page#1088

Merged
danielroe merged 1 commit intonpmx-dev:mainfrom
userquin:chore-remove-back-button-title-at-private-page
Feb 6, 2026
Merged

fix(ui): remove back button title on privacy page#1088
danielroe merged 1 commit intonpmx-dev:mainfrom
userquin:chore-remove-back-button-title-at-private-page

Conversation

@userquin
Copy link
Member

@userquin userquin commented Feb 6, 2026

This PR removes the button title but change the span styles with the back text to use sr-only sm:not-sr-only.

@vercel
Copy link

vercel bot commented Feb 6, 2026

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
npmx.dev Ready Ready Preview, Comment Feb 6, 2026 0:00am
2 Skipped Deployments
Project Deployment Actions Updated (UTC)
docs.npmx.dev Ignored Ignored Preview Feb 6, 2026 0:00am
npmx-lunaria Ignored Ignored Feb 6, 2026 0:00am

Request Review

@codecov
Copy link

codecov bot commented Feb 6, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ All tests successful. No failed tests found.

📢 Thoughts on this report? Let us know!

@coderabbitai
Copy link
Contributor

coderabbitai bot commented Feb 6, 2026

📝 Walkthrough

Walkthrough

This pull request modifies the back button markup in the privacy page. The change removes the title attribute binding that previously provided a desktop tooltip, and adjusts the visibility classes for the back button label. The label is now hidden visually on small screens while remaining accessible to screen readers, and becomes visible on larger viewports starting at the small breakpoint. The file sees a net change of one line added and two lines removed.

Possibly related PRs

Suggested reviewers

  • danielroe
🚥 Pre-merge checks | ✅ 1
✅ Passed checks (1 passed)
Check name Status Explanation
Description check ✅ Passed The pull request description accurately describes the changeset: removing the button title and updating span styles with sr-only sm:not-sr-only classes.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment

Comment @coderabbitai help to get the list of available commands and usage tips.

@danielroe danielroe changed the title chore(ui): remove back button title at privacy page fix(ui): remove back button title on privacy page Feb 6, 2026
@danielroe danielroe added this pull request to the merge queue Feb 6, 2026
Merged via the queue into npmx-dev:main with commit 9394632 Feb 6, 2026
18 checks passed
@userquin userquin deleted the chore-remove-back-button-title-at-private-page branch February 6, 2026 12:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants