Skip to content

Comments

chore: consistent back button across pages#936

Merged
danielroe merged 1 commit intonpmx-dev:mainfrom
iiio2:chore/consistent-back-button
Feb 4, 2026
Merged

chore: consistent back button across pages#936
danielroe merged 1 commit intonpmx-dev:mainfrom
iiio2:chore/consistent-back-button

Conversation

@iiio2
Copy link
Contributor

@iiio2 iiio2 commented Feb 4, 2026

resolves #918

page-one page-two page-three

@vercel
Copy link

vercel bot commented Feb 4, 2026

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
npmx.dev Ready Ready Preview, Comment Feb 4, 2026 1:21pm
2 Skipped Deployments
Project Deployment Actions Updated (UTC)
docs.npmx.dev Ignored Ignored Preview Feb 4, 2026 1:21pm
npmx-lunaria Ignored Ignored Feb 4, 2026 1:21pm

Request Review

@codecov
Copy link

codecov bot commented Feb 4, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ All tests successful. No failed tests found.

📢 Thoughts on this report? Let us know!

@coderabbitai
Copy link
Contributor

coderabbitai bot commented Feb 4, 2026

📝 Walkthrough

Walkthrough

Both about.vue and compare.vue pages have been updated to include back navigation buttons within their headers using the useRouter composable. The back buttons trigger router.back() on click. In about.vue, the back button replaces a footer NuxtLink to the home page, whilst in compare.vue, the back button is integrated into a new flexible header layout. Both implementations include locale-aware labelling on larger screens and navigational iconography.

🚥 Pre-merge checks | ✅ 2 | ❌ 1
❌ Failed checks (1 warning)
Check name Status Explanation Resolution
Linked Issues check ⚠️ Warning The PR adds consistent back buttons to about.vue and compare.vue pages, but does not address the main objective of handling the collapsed logo/homepage navigation on smaller viewports (~640px). Implement the suggested solution to separate the search icon from the logo and ensure the logo persistently returns to the homepage across all viewports, particularly on mobile devices.
✅ Passed checks (2 passed)
Check name Status Explanation
Description check ✅ Passed The PR description references issue #918 with supporting screenshots, directly relating to the changeset's navigation improvements.
Out of Scope Changes check ✅ Passed The changes are focused solely on adding back buttons to two pages, which is directly scoped to the linked issue's consistency concerns.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment

Comment @coderabbitai help to get the list of available commands and usage tips.

@danielroe danielroe added this pull request to the merge queue Feb 4, 2026
Merged via the queue into npmx-dev:main with commit 38cbfe0 Feb 4, 2026
16 checks passed
@iiio2
Copy link
Contributor Author

iiio2 commented Feb 4, 2026

Thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Inconsitent ways to return to homepage

2 participants