Skip to content

Comments

feat(ui): add mobile buttons for package nav, and wrap badges#1188

Merged
serhalp merged 3 commits intomainfrom
feat/header-nav
Feb 8, 2026
Merged

feat(ui): add mobile buttons for package nav, and wrap badges#1188
serhalp merged 3 commits intomainfrom
feat/header-nav

Conversation

@danielroe
Copy link
Member

this forced badges on to a new line, to reduce layout shift

it also moves the top sub nav bar (docs/compare/code) to a floating nav bar at the bottom on mobile:

before Screen Shot 2026-02-08 at 01 46 07
after Screen Shot 2026-02-08 at 01 46 05

@vercel
Copy link

vercel bot commented Feb 8, 2026

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
npmx.dev Ready Ready Preview, Comment Feb 8, 2026 1:52am
2 Skipped Deployments
Project Deployment Actions Updated (UTC)
docs.npmx.dev Ignored Ignored Preview Feb 8, 2026 1:52am
npmx-lunaria Ignored Ignored Feb 8, 2026 1:52am

Request Review

@danielroe danielroe changed the title feat: add mobile buttons for package nav, and wrap badges feat(ui): add mobile buttons for package nav, and wrap badges Feb 8, 2026
@danielroe danielroe added the front Frontend, Design label Feb 8, 2026
@codecov
Copy link

codecov bot commented Feb 8, 2026

Codecov Report

❌ Patch coverage is 45.45455% with 6 lines in your changes missing coverage. Please review.
✅ All tests successful. No failed tests found.

Files with missing lines Patch % Lines
app/pages/package/[[org]]/[name].vue 33.33% 6 Missing ⚠️

📢 Thoughts on this report? Let us know!

@coderabbitai
Copy link
Contributor

coderabbitai bot commented Feb 8, 2026

📝 Walkthrough

Walkthrough

This pull request refines layout and responsive navigation on the package detail page and its skeleton component. The skeleton's header spacing is split into horizontal and vertical gap classes, the metrics badges container is changed to a full-width basis layout, and an additional skeleton badge block was added. The package page replaces the previous inline metrics block with a desktop inline ButtonGroup and a new mobile floating bottom navigation, adjusts header gap handling, updates metrics-badges positioning, and adds CSS for the mobile nav and bottom padding.

Possibly related PRs

🚥 Pre-merge checks | ✅ 1
✅ Passed checks (1 passed)
Check name Status Explanation
Description check ✅ Passed The pull request description clearly describes the changeset: forcing badges onto a new line to reduce layout shift and moving the sub navigation bar to a floating bottom navigation on mobile, supported by before/after screenshots.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch feat/header-nav

No actionable comments were generated in the recent review. 🎉


Comment @coderabbitai help to get the list of available commands and usage tips.

Copy link
Contributor

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

Copy link
Member

@serhalp serhalp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great! 💯

@serhalp serhalp added this pull request to the merge queue Feb 8, 2026
Merged via the queue into main with commit e77dcf9 Feb 8, 2026
20 checks passed
@serhalp serhalp deleted the feat/header-nav branch February 8, 2026 02:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

front Frontend, Design

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants