Skip to content

Comments

fix: correct mobile bottom navigation in RTL language#1316

Merged
whitep4nth3r merged 1 commit intonpmx-dev:mainfrom
shuuji3:fix/mobile-bottom-navigation-location-on-rtl-lang
Feb 10, 2026
Merged

fix: correct mobile bottom navigation in RTL language#1316
whitep4nth3r merged 1 commit intonpmx-dev:mainfrom
shuuji3:fix/mobile-bottom-navigation-location-on-rtl-lang

Conversation

@shuuji3
Copy link
Member

@shuuji3 shuuji3 commented Feb 10, 2026

fix #1315

  • The rtl: prefix can be used to apply unocss class only to RTL locales.
  • I also replced 50% with 1/2 to be consistent with other usages.

Before

screenshot of package page on mobile. only a small edge of nav is shown at the bottom left screen

After

screenshot of package page on mobile. bottom nav is fully shown at the bottom center of the screen

@vercel
Copy link

vercel bot commented Feb 10, 2026

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
npmx.dev Ready Ready Preview, Comment Feb 10, 2026 6:36am
2 Skipped Deployments
Project Deployment Actions Updated (UTC)
docs.npmx.dev Ignored Ignored Preview Feb 10, 2026 6:36am
npmx-lunaria Ignored Ignored Feb 10, 2026 6:36am

Request Review

@coderabbitai
Copy link
Contributor

coderabbitai bot commented Feb 10, 2026

📝 Walkthrough

Walkthrough

This pull request updates the mobile navigation positioning in the package page component. The styling changes replace the previous inset and translate approach with a more precise centering method, including RTL-specific translation adjustments. The modification addresses layout issues observed on small screens, particularly in right-to-left language configurations. No functional logic, error handling, or control-flow changes are introduced.

Possibly related PRs

Suggested labels

front

Suggested reviewers

  • danielroe
  • serhalp
🚥 Pre-merge checks | ✅ 3
✅ Passed checks (3 passed)
Check name Status Explanation
Linked Issues check ✅ Passed The pull request directly addresses the objective stated in issue #1315 by applying RTL-specific CSS styling to ensure the bottom navigation is fully visible and centred on mobile devices in RTL locales.
Out of Scope Changes check ✅ Passed All changes are within scope; the pull request modifies only the package navigation styling to fix the RTL mobile layout issue described in issue #1315, with no unrelated alterations.
Description check ✅ Passed The pull request description clearly describes the changes made: fixing RTL mobile navigation positioning, adding rtl: prefix, replacing 50% with 1/2, and includes before/after screenshots demonstrating the fix.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment

Comment @coderabbitai help to get the list of available commands and usage tips.

@codecov
Copy link

codecov bot commented Feb 10, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ All tests successful. No failed tests found.

📢 Thoughts on this report? Let us know!

@whitep4nth3r whitep4nth3r added this pull request to the merge queue Feb 10, 2026
Merged via the queue into npmx-dev:main with commit 2801235 Feb 10, 2026
19 checks passed
@shuuji3 shuuji3 deleted the fix/mobile-bottom-navigation-location-on-rtl-lang branch February 10, 2026 11:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Bottom mobile navigation in RTL language

2 participants