Skip to content

Comments

feat: use default cursor for non-link items#1216

Merged
alexdln merged 1 commit intonpmx-dev:mainfrom
kalu5:feat/1074
Feb 8, 2026
Merged

feat: use default cursor for non-link items#1216
alexdln merged 1 commit intonpmx-dev:mainfrom
kalu5:feat/1074

Conversation

@kalu5
Copy link
Contributor

@kalu5 kalu5 commented Feb 8, 2026

@vercel
Copy link

vercel bot commented Feb 8, 2026

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
npmx.dev Ready Ready Preview, Comment Feb 8, 2026 2:59pm
2 Skipped Deployments
Project Deployment Actions Updated (UTC)
docs.npmx.dev Ignored Ignored Preview Feb 8, 2026 2:59pm
npmx-lunaria Ignored Ignored Feb 8, 2026 2:59pm

Request Review

@codecov
Copy link

codecov bot commented Feb 8, 2026

Codecov Report

❌ Patch coverage is 83.33333% with 1 line in your changes missing coverage. Please review.
✅ All tests successful. No failed tests found.

Files with missing lines Patch % Lines
app/components/ColumnPicker.vue 0.00% 1 Missing ⚠️

📢 Thoughts on this report? Let us know!

@coderabbitai
Copy link
Contributor

coderabbitai bot commented Feb 8, 2026

📝 Walkthrough

Walkthrough

This pull request systematically removes cursor-pointer styling across the application. The changes include deleting the cursor: pointer; CSS rule from the button reset in main.css and removing the cursor-pointer utility class from approximately 17 Vue components. These components span multiple features including package management, settings, modals, and various interactive UI elements such as select dropdowns, labels, buttons, and summary elements. The functional behaviour of these interactive elements remains unchanged; only the visual cursor indication is altered.

Possibly related PRs

Suggested reviewers

  • danielroe
🚥 Pre-merge checks | ✅ 1
✅ Passed checks (1 passed)
Check name Status Explanation
Description check ✅ Passed The pull request description references issue #1074, which aligns with the changeset of removing cursor-pointer utilities across multiple UI components.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment

Comment @coderabbitai help to get the list of available commands and usage tips.

Copy link
Contributor

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

@alexdln alexdln added this pull request to the merge queue Feb 8, 2026
@alexdln
Copy link
Member

alexdln commented Feb 8, 2026

Excellent work, clean and accurate, thanks

Would you like to continue with that focus part?

Merged via the queue into npmx-dev:main with commit adc8d07 Feb 8, 2026
17 checks passed
@kalu5
Copy link
Contributor Author

kalu5 commented Feb 8, 2026

Excellent work, clean and accurate, thanks

Would you like to continue with that focus part?

I am very willing.

@alexdln
Copy link
Member

alexdln commented Feb 8, 2026

We already have an issue for this. If I can help in any way, please feel free to reach me in that issue/PR comments or in chat.npmx.dev

We recently added global focus, but when navigating through tab, it's visible that it didn't work so well - in some places the old focus remains, in some places the focus is done through the ring and not outline, in some places there is nested focus, and in some places it just looks strange.

We definitely need to get rid of the ring and finally unify experience. If it's more convenient for you, create separate PRs (like for removing ring and then for polishing)

We're also thinking of going away from global styles, so join us on discord to stay up to date

#647

@kalu5
Copy link
Contributor Author

kalu5 commented Feb 9, 2026

We already have an issue for this. If I can help in any way, please feel free to reach me in that issue/PR comments or in chat.npmx.dev

We recently added global focus, but when navigating through tab, it's visible that it didn't work so well - in some places the old focus remains, in some places the focus is done through the ring and not outline, in some places there is nested focus, and in some places it just looks strange.

We definitely need to get rid of the ring and finally unify experience. If it's more convenient for you, create separate PRs (like for removing ring and then for polishing)

We're also thinking of going away from global styles, so join us on discord to stay up to date

#647

Ok! Let me see what's going on.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants