feat: use default cursor for non-link items#1216
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
2 Skipped Deployments
|
Codecov Report❌ Patch coverage is
📢 Thoughts on this report? Let us know! |
📝 WalkthroughWalkthroughThis pull request systematically removes Possibly related PRs
Suggested reviewers
🚥 Pre-merge checks | ✅ 1✅ Passed checks (1 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing touches🧪 Generate unit tests (beta)
Comment |
|
Excellent work, clean and accurate, thanks Would you like to continue with that focus part? |
I am very willing. |
|
We already have an issue for this. If I can help in any way, please feel free to reach me in that issue/PR comments or in chat.npmx.dev We recently added global focus, but when navigating through tab, it's visible that it didn't work so well - in some places the old focus remains, in some places the focus is done through the ring and not outline, in some places there is nested focus, and in some places it just looks strange. We definitely need to get rid of the ring and finally unify experience. If it's more convenient for you, create separate PRs (like for removing ring and then for polishing) We're also thinking of going away from global styles, so join us on discord to stay up to date |
Ok! Let me see what's going on. |
#1074