Skip to content

Comments

fix: add cursor pointer to button and list items#1317

Merged
whitep4nth3r merged 1 commit intonpmx-dev:mainfrom
NandkishorJadoun:fix/cursor-pointer-dropdown
Feb 10, 2026
Merged

fix: add cursor pointer to button and list items#1317
whitep4nth3r merged 1 commit intonpmx-dev:mainfrom
NandkishorJadoun:fix/cursor-pointer-dropdown

Conversation

@NandkishorJadoun
Copy link
Contributor

Description

Previously, the trigger button and dropdown options showed the default arrow cursor, which made the UI feel non interactive. This pr updates the cursor style for the package manager selector to use a pointer cursor on interactive elements.

Changes:

  • Added cursor-pointer to the dropdown trigger
  • Added cursor-pointer to clickable dropdown options

@vercel
Copy link

vercel bot commented Feb 10, 2026

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
npmx.dev Ready Ready Preview, Comment Feb 10, 2026 6:53am
2 Skipped Deployments
Project Deployment Actions Updated (UTC)
docs.npmx.dev Ignored Ignored Preview Feb 10, 2026 6:53am
npmx-lunaria Ignored Ignored Feb 10, 2026 6:53am

Request Review

@coderabbitai
Copy link
Contributor

coderabbitai bot commented Feb 10, 2026

📝 Walkthrough

Walkthrough

The pull request modifies the ManagerSelect component to add cursor-pointer styling classes to interactive elements. Specifically, the cursor-pointer utility class is added to the trigger button and each option item within the component. The change consists of two lines added and two lines removed, affecting only the class bindings without altering control flow, event handling, data bindings, or accessibility properties.

Possibly related PRs

Suggested reviewers

  • alexdln
  • danielroe
🚥 Pre-merge checks | ✅ 1
✅ Passed checks (1 passed)
Check name Status Explanation
Description check ✅ Passed The pull request description accurately describes the changeset, explaining the cursor style improvements to interactive elements in the package manager selector.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment

Comment @coderabbitai help to get the list of available commands and usage tips.

Copy link
Contributor

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

Comment on lines 88 to 92
<button
ref="triggerRef"
type="button"
class="flex items-center gap-1.5 px-2 py-2 font-mono text-xs text-fg-muted bg-bg-subtle border border-border-subtle border-solid rounded-md transition-colors duration-150 hover:(text-fg border-border-hover) active:scale-95 focus:border-border-hover focus-visible:outline-accent/70 hover:text-fg"
class="cursor-pointer flex items-center gap-1.5 px-2 py-2 font-mono text-xs text-fg-muted bg-bg-subtle border border-border-subtle border-solid rounded-md transition-colors duration-150 hover:(text-fg border-border-hover) active:scale-95 focus:border-border-hover focus-visible:outline-accent/70 hover:text-fg"
:aria-expanded="isOpen"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Potential issue | 🟡 Minor

Remove the per-element focus-visible utility from the button class.

Focus-visible styling for buttons is already handled globally; keeping focus-visible:outline-accent/70 here conflicts with the project rule. Please drop it while you’re touching this class list.

Proposed change
-    class="cursor-pointer flex items-center gap-1.5 px-2 py-2 font-mono text-xs text-fg-muted bg-bg-subtle border border-border-subtle border-solid rounded-md transition-colors duration-150 hover:(text-fg border-border-hover) active:scale-95 focus:border-border-hover focus-visible:outline-accent/70 hover:text-fg"
+    class="cursor-pointer flex items-center gap-1.5 px-2 py-2 font-mono text-xs text-fg-muted bg-bg-subtle border border-border-subtle border-solid rounded-md transition-colors duration-150 hover:(text-fg border-border-hover) active:scale-95 focus:border-border-hover hover:text-fg"

Based on learnings: “In the npmx.dev project, ensure that focus-visible styling for button and select elements is implemented globally in app/assets/main.css… Do not apply per-element inline utility classes like focus-visible:outline-accent/70 on these elements.”

@codecov
Copy link

codecov bot commented Feb 10, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ All tests successful. No failed tests found.

📢 Thoughts on this report? Let us know!

@whitep4nth3r whitep4nth3r added this pull request to the merge queue Feb 10, 2026
Merged via the queue into npmx-dev:main with commit f0e38c1 Feb 10, 2026
17 checks passed
@NandkishorJadoun NandkishorJadoun deleted the fix/cursor-pointer-dropdown branch February 10, 2026 10:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants