fix: add cursor pointer to button and list items#1317
fix: add cursor pointer to button and list items#1317whitep4nth3r merged 1 commit intonpmx-dev:mainfrom
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
2 Skipped Deployments
|
📝 WalkthroughWalkthroughThe pull request modifies the ManagerSelect component to add cursor-pointer styling classes to interactive elements. Specifically, the cursor-pointer utility class is added to the trigger button and each option item within the component. The change consists of two lines added and two lines removed, affecting only the class bindings without altering control flow, event handling, data bindings, or accessibility properties. Possibly related PRs
Suggested reviewers
🚥 Pre-merge checks | ✅ 1✅ Passed checks (1 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing touches🧪 Generate unit tests (beta)
Comment |
| <button | ||
| ref="triggerRef" | ||
| type="button" | ||
| class="flex items-center gap-1.5 px-2 py-2 font-mono text-xs text-fg-muted bg-bg-subtle border border-border-subtle border-solid rounded-md transition-colors duration-150 hover:(text-fg border-border-hover) active:scale-95 focus:border-border-hover focus-visible:outline-accent/70 hover:text-fg" | ||
| class="cursor-pointer flex items-center gap-1.5 px-2 py-2 font-mono text-xs text-fg-muted bg-bg-subtle border border-border-subtle border-solid rounded-md transition-colors duration-150 hover:(text-fg border-border-hover) active:scale-95 focus:border-border-hover focus-visible:outline-accent/70 hover:text-fg" | ||
| :aria-expanded="isOpen" |
There was a problem hiding this comment.
Remove the per-element focus-visible utility from the button class.
Focus-visible styling for buttons is already handled globally; keeping focus-visible:outline-accent/70 here conflicts with the project rule. Please drop it while you’re touching this class list.
Proposed change
- class="cursor-pointer flex items-center gap-1.5 px-2 py-2 font-mono text-xs text-fg-muted bg-bg-subtle border border-border-subtle border-solid rounded-md transition-colors duration-150 hover:(text-fg border-border-hover) active:scale-95 focus:border-border-hover focus-visible:outline-accent/70 hover:text-fg"
+ class="cursor-pointer flex items-center gap-1.5 px-2 py-2 font-mono text-xs text-fg-muted bg-bg-subtle border border-border-subtle border-solid rounded-md transition-colors duration-150 hover:(text-fg border-border-hover) active:scale-95 focus:border-border-hover hover:text-fg"Based on learnings: “In the npmx.dev project, ensure that focus-visible styling for button and select elements is implemented globally in app/assets/main.css… Do not apply per-element inline utility classes like focus-visible:outline-accent/70 on these elements.”
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
Description
Previously, the trigger button and dropdown options showed the default arrow cursor, which made the UI feel non interactive. This pr updates the cursor style for the package manager selector to use a pointer cursor on interactive elements.
Changes:
cursor-pointerto the dropdown triggercursor-pointerto clickable dropdown options