Skip to content

Comments

feat(i18n): add missing zh-CN translations for shortcuts, data source…#1250

Merged
serhalp merged 1 commit intonpmx-dev:mainfrom
penjj:main
Feb 9, 2026
Merged

feat(i18n): add missing zh-CN translations for shortcuts, data source…#1250
serhalp merged 1 commit intonpmx-dev:mainfrom
penjj:main

Conversation

@penjj
Copy link
Contributor

@penjj penjj commented Feb 9, 2026

Add missing Chinese (zh-CN) translations for:

  1. Keyboard shortcuts.
  2. Search data source settings.
  3. Search feedback messages .
  4. Package trends.
  5. Compare page trends facet.
  6. Auth modal error message.

@vercel
Copy link

vercel bot commented Feb 9, 2026

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
npmx.dev Ready Ready Preview, Comment Feb 9, 2026 1:36am
2 Skipped Deployments
Project Deployment Actions Updated (UTC)
docs.npmx.dev Ignored Ignored Preview Feb 9, 2026 1:36am
npmx-lunaria Ignored Ignored Feb 9, 2026 1:36am

Request Review

@github-actions
Copy link

github-actions bot commented Feb 9, 2026

Lunaria Status Overview

🌕 This pull request will trigger status changes.

Learn more

By default, every PR changing files present in the Lunaria configuration's files property will be considered and trigger status changes accordingly.

You can change this by adding one of the keywords present in the ignoreKeywords property in your Lunaria configuration file in the PR's title (ignoring all files) or by including a tracker directive in the merged commit's description.

Tracked Files

File Note
lunaria/files/zh-CN.json Localization changed, will be marked as complete.
Warnings reference
Icon Description
🔄️ The source for this localization has been updated since the creation of this pull request, make sure all changes in the source have been applied.

@codecov
Copy link

codecov bot commented Feb 9, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ All tests successful. No failed tests found.

📢 Thoughts on this report? Let us know!

@coderabbitai
Copy link
Contributor

coderabbitai bot commented Feb 9, 2026

📝 Walkthrough

Walkthrough

This PR updates the Chinese (zh-CN) locale JSON by adding keyboard-shortcuts entries (footer and top-level shortcuts block), expanded search messages (sorted results, rate limiting, Algolia disclaimer), a new settings.data_source block (npm and Algolia labels/descriptions), an Atmosphere/auth default_input_error, and a trends block (title, no_data, y_axis_label, downloads). Changes are limited to localization keys (+41/−3 lines).

Possibly related PRs

Suggested reviewers

  • danielroe
🚥 Pre-merge checks | ✅ 1
✅ Passed checks (1 passed)
Check name Status Explanation
Description check ✅ Passed The pull request description clearly outlines the addition of missing Chinese (zh-CN) translations, directly matching the changeset which adds translations for keyboard shortcuts, data source settings, search messages, trends, and auth errors.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment

No actionable comments were generated in the recent review. 🎉


Comment @coderabbitai help to get the list of available commands and usage tips.

Copy link
Contributor

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 2

Copy link
Member

@serhalp serhalp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants