Skip to content

Comments

chore(i18n): add missing german translations#1262

Merged
danielroe merged 6 commits intonpmx-dev:mainfrom
Pascalmh:chrore/i18n-german
Feb 9, 2026
Merged

chore(i18n): add missing german translations#1262
danielroe merged 6 commits intonpmx-dev:mainfrom
Pascalmh:chrore/i18n-german

Conversation

@Pascalmh
Copy link
Contributor

@Pascalmh Pascalmh commented Feb 9, 2026

Ran pnpm i18n:check:fix de-DE and added most of the missing translations

@vercel
Copy link

vercel bot commented Feb 9, 2026

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
npmx.dev Ready Ready Preview, Comment Feb 9, 2026 9:07am
2 Skipped Deployments
Project Deployment Actions Updated (UTC)
docs.npmx.dev Ignored Ignored Preview Feb 9, 2026 9:07am
npmx-lunaria Ignored Ignored Feb 9, 2026 9:07am

Request Review

@github-actions
Copy link

github-actions bot commented Feb 9, 2026

Lunaria Status Overview

🌕 This pull request will trigger status changes.

Learn more

By default, every PR changing files present in the Lunaria configuration's files property will be considered and trigger status changes accordingly.

You can change this by adding one of the keywords present in the ignoreKeywords property in your Lunaria configuration file in the PR's title (ignoring all files) or by including a tracker directive in the merged commit's description.

Tracked Files

File Note
lunaria/files/de-DE.json Localization changed, will be marked as complete.
Warnings reference
Icon Description
🔄️ The source for this localization has been updated since the creation of this pull request, make sure all changes in the source have been applied.

"button": "Suchen",
"searching": "Suche läuft...",
"found_packages": "Keine Pakete gefunden | 1 Paket gefunden | {count} Pakete gefunden",
"found_packages_sorted": "Sortiere bestes Resultat | Sortiere beste {count} Resultate",
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The english translation for this key is

Sorting top {count} result | Sorting top {count} results

How can a single result be sorted?

@codecov
Copy link

codecov bot commented Feb 9, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ All tests successful. No failed tests found.

📢 Thoughts on this report? Let us know!

@coderabbitai
Copy link
Contributor

coderabbitai bot commented Feb 9, 2026

📝 Walkthrough

Walkthrough

This change updates the German locale (de-DE.json): adds a top-level shortcuts section and footer.keyboard_shortcuts; introduces search keys (found_packages_sorted, rate_limited); exposes settings.sections.search ("Datenquelle"); moves likes from package.replacement to package.links; adds facets.totalLikes and downloads.totalLikes; introduces a facets.trends block and a package.trends section (weekly downloads) with granularity, date, loading and legend keys; and replaces a prior trends block with a size block (units b, kb, mb).

Possibly related PRs

Suggested reviewers

  • danielroe
  • ghostdevv
🚥 Pre-merge checks | ✅ 1
✅ Passed checks (1 passed)
Check name Status Explanation
Description check ✅ Passed The pull request description accurately describes the changeset, which adds missing German translations by running the i18n:check:fix command.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment

Comment @coderabbitai help to get the list of available commands and usage tips.

Copy link
Contributor

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 2

Pascalmh and others added 3 commits February 9, 2026 09:54
Co-authored-by: coderabbitai[bot] <136622811+coderabbitai[bot]@users.noreply.github.com>
Co-authored-by: coderabbitai[bot] <136622811+coderabbitai[bot]@users.noreply.github.com>
Copy link
Contributor

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

Copy link
Contributor

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

"social": "Social",
"chat": "Chat"
"chat": "Chat",
"keyboard_shortcuts": "Tastenkombination"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Potential issue | 🟡 Minor

Consider using plural form "Tastenkombinationen".

The key keyboard_shortcuts implies multiple shortcuts, and the associated shortcuts section (lines 21-35) defines many key bindings. The singular "Tastenkombination" should be "Tastenkombinationen" for grammatical consistency.

📝 Suggested fix
-    "keyboard_shortcuts": "Tastenkombination"
+    "keyboard_shortcuts": "Tastenkombinationen"
📝 Committable suggestion

‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.

Suggested change
"keyboard_shortcuts": "Tastenkombination"
"keyboard_shortcuts": "Tastenkombinationen"

@danielroe danielroe added this pull request to the merge queue Feb 9, 2026
Merged via the queue into npmx-dev:main with commit 4e43b85 Feb 9, 2026
17 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants