Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
2 Skipped Deployments
|
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
|
No actionable comments were generated in the recent review. 🎉 📝 WalkthroughWalkthroughThis PR removes the "Add to calendar" logic and UI from the recharging page (ICS generation, Possibly related PRs
Suggested reviewers
🚥 Pre-merge checks | ✅ 1✅ Passed checks (1 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 2
🧹 Nitpick comments (2)
vercel.json (1)
13-13: Verify the Discord invite link is set to never expire.
https://discord.gg/x9KE5U2q8wis now the sole destination for allchat.npmx.devtraffic. If this invite was created with a usage cap or expiry date, the redirect will silently deliver a broken link to every user.Confirm in Discord Server Settings → Invites that this invite is set to never expire and has no usage limit.
app/pages/recharging.vue (1)
61-101: Remove the now-deadfmtanddownloadIcsfunctions.The "Add to calendar" button that invoked
downloadIcswas removed from the template as part of this PR, leaving both thefmthelper (lines 64–69) and the entiredownloadIcsfunction (lines 72–101), along with the section comment (line 61), as unreachable dead code.♻️ Proposed clean-up
-// --- .ics calendar reminder --- - -// Format as UTC for the .ics file -const fmt = (d: Date) => - d - .toISOString() - .replace(/[-:]/g, '') - .replace(/\.\d{3}/, '') - -// Pick a random daytime hour (9–17) in the user's local timezone on Feb 22 -// so reminders are staggered and people don't all flood in at once. -function downloadIcs() { - const hour = 9 + Math.floor(Math.random() * 9) // 9..17 - const start = new Date(2026, 1, 22, hour, 0, 0) // month is 0-indexed - const end = new Date(2026, 1, 22, hour + 1, 0, 0) - - const uid = `npmx-vacations-${start.getTime()}@npmx.dev` - - const ics = [ - 'BEGIN:VCALENDAR', - 'VERSION:2.0', - 'PRODID:-//npmx//recharging//EN', - 'BEGIN:VEVENT', - `DTSTART:${fmt(start)}`, - `DTEND:${fmt(end)}`, - `SUMMARY:npmx Discord is back!`, - `DESCRIPTION:The npmx team is back from vacation. Time to rejoin! https://chat.npmx.dev`, - 'STATUS:CONFIRMED', - `UID:${uid}`, - 'END:VEVENT', - 'END:VCALENDAR', - ].join('\r\n') - - const blob = new Blob([ics], { type: 'text/calendar;charset=utf-8' }) - const url = URL.createObjectURL(blob) - const a = document.createElement('a') - a.href = url - a.download = 'npmx-discord-reminder.ics' - a.click() - URL.revokeObjectURL(url) -}
|
@patak-dev Hi, #1560 could fix the build failure. I'll ask Yan if this is the correct version we can use but we could merge it if we want a quick fix. |
3 participants
Let's wait a few hours to merge this, at least until 10am CET so we have time to unlock other channels and slowly get back to them. This PR:
/rechargingin past tense so we can still use the link to talk with others about our vacation. After March 3rd, we can reword it again to tease our summer vacation.