Skip to content

Comments

chore: update expired @lunariajs/core pkg.pr.new package#1560

Merged
danielroe merged 1 commit intonpmx-dev:mainfrom
shuuji3:chore/update-lunariajs-core-package
Feb 22, 2026
Merged

chore: update expired @lunariajs/core pkg.pr.new package#1560
danielroe merged 1 commit intonpmx-dev:mainfrom
shuuji3:chore/update-lunariajs-core-package

Conversation

@shuuji3
Copy link
Member

@shuuji3 shuuji3 commented Feb 22, 2026

fix #1547

@vercel
Copy link

vercel bot commented Feb 22, 2026

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
docs.npmx.dev Ready Ready Preview, Comment Feb 22, 2026 6:45am
npmx.dev Ready Ready Preview, Comment Feb 22, 2026 6:45am
1 Skipped Deployment
Project Deployment Actions Updated (UTC)
npmx-lunaria Ignored Ignored Feb 22, 2026 6:45am

Request Review

@coderabbitai
Copy link
Contributor

coderabbitai bot commented Feb 22, 2026

📝 Walkthrough

Walkthrough

The package.json file has been updated to refresh the @lunariajs/core dependency reference. The package URL was changed from pointing to commit/tag f07e1a3 to the newer commit/tag 904b935 within the pkg.pr.new service. This update addresses the expiration of the previous preview deployment package and restores access to a current version of the dependency.

🚥 Pre-merge checks | ✅ 3
✅ Passed checks (3 passed)
Check name Status Explanation
Description check ✅ Passed The PR description directly references issue #1547, which is the linked issue about the expired package that this PR addresses.
Linked Issues check ✅ Passed The PR successfully updates the expired @lunariajs/core pkg.pr.new package to a newer commit version, directly addressing the objective in issue #1547.
Out of Scope Changes check ✅ Passed All changes are within scope—only the @lunariajs/core dependency URL has been updated from an expired commit to a newer one, directly aligned with issue #1547 objectives.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

Copy link
Contributor

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

"@iconify-json/vscode-icons": "1.2.40",
"@intlify/shared": "11.2.8",
"@lunariajs/core": "https://pkg.pr.new/lunariajs/lunaria/@lunariajs/core@f07e1a3",
"@lunariajs/core": "https://pkg.pr.new/lunariajs/lunaria/@lunariajs/core@904b935",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Potential issue | 🟠 Major

🧩 Analysis chain

🌐 Web query:

pkg.pr.new package expiry policy temporary registry

💡 Result:

pkg.pr.new is explicitly a temporary, npm-compatible preview registry, not a permanent package host. (blog.stackblitz.com)

From the published infrastructure notes on its storage management:

  • Inactive cleanup: preview packages that are at least 1 month old and haven’t been downloaded in over 1 month are automatically removed. (gist.github.com)
  • Hard max age: any preview package older than 6 months is removed, even if it’s still being downloaded. (gist.github.com)

Citations:


🌐 Web query:

pnpm github git dependency syntax package.json

💡 Result:

pnpm supports the standard npm “git dependency” spec in package.json, including GitHub shorthands.

GitHub shorthand (most common)

{
  "dependencies": {
    "my-lib": "user/repo",
    "my-lib-commit": "user/repo#97edff6f525f192a3f83cea1944765f769ae2678",
    "my-lib-branch": "user/repo#master",
    "my-lib-semver-tags": "user/repo#semver:^2.0.0"
  }
}

pnpm documents the same forms via pnpm add (commit / branch / #semver:). [1]

Explicit github: (equivalent style)

{
  "dependencies": {
    "my-lib": "github:user/repo#HEAD"
  }
}

npm’s package spec documents github:user/repo#ref and user/repo#ref as valid git shorthands. [2]

Full git URLs (HTTPS/SSH) + ref

{
  "dependencies": {
    "my-lib-https": "git+https://github.com/user/repo.git#v1.2.3",
    "my-lib-ssh": "git+ssh://git@github.com/user/repo.git#v1.2.3"
  }
}

This is the canonical “git URL as dependency” form per npm’s package spec. [2]

Notes

  • The part after # can be a tag, branch, or commit SHA; #semver:<range> selects a matching tag/ref (when available). [1][2][3]
  • You can also do this from the CLI and let pnpm write it: pnpm add github:user/repo#<ref>. [1]

Sources: pnpm add docs [1], npm package spec (git URLs & GitHub shorthands) [2], pnpm Git install examples (#commit, #branch, #semver) [3].


🌐 Web query:

@lunariajs/core v1 release npm stable version

💡 Result:

As of the latest npm publish information available, @lunariajs/core does not have a v1.x stable release. The current stable (“latest”) version on npm is 0.1.1. [1]

Lunaria’s own announcement also frames the project’s first public release as v0.1, indicating it’s still pre-1.0. [2]

Sources: [1], [2]


pkg.pr.new references are ephemeral — this will expire again.

pkg.pr.new publishes unreleased packages to a temporary npm-compatible preview registry. Packages are automatically removed if they're at least 1 month old and haven't been downloaded in over a month, or if they exceed 6 months old regardless of download activity. This PR swaps one expired commit hash for another, but the new reference (904b935) will expire under exactly the same conditions, causing the same deploy failure to recur.

Consider switching to a non-expiring alternative until @lunariajs/core v1 lands on npm as a stable release:

♻️ Suggested alternative: git dependency (does not expire)
-    "@lunariajs/core": "https://pkg.pr.new/lunariajs/lunaria/@lunariajs/core@904b935",
+    "@lunariajs/core": "github:lunariajs/lunaria#904b935",

Once the v1 branch publishes a stable release to the npm registry, migrate to a pinned semver version (e.g. "@lunariajs/core": "^1.0.0") to eliminate this class of breakage entirely.

📝 Committable suggestion

‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.

Suggested change
"@lunariajs/core": "https://pkg.pr.new/lunariajs/lunaria/@lunariajs/core@904b935",
"@lunariajs/core": "github:lunariajs/lunaria#904b935",

@codecov
Copy link

codecov bot commented Feb 22, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ All tests successful. No failed tests found.

📢 Thoughts on this report? Let us know!

@shuuji3 shuuji3 mentioned this pull request Feb 22, 2026
@shuuji3
Copy link
Member Author

shuuji3 commented Feb 22, 2026

The lunaria workflow failure is caused by the exact issue that this PR is trying to fix.

@danielroe danielroe merged commit 3d690ea into npmx-dev:main Feb 22, 2026
17 of 18 checks passed
@shuuji3 shuuji3 deleted the chore/update-lunariajs-core-package branch February 22, 2026 08:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

@lunariajs/core pkg.pr.new package has expired

2 participants