Skip to content

fix(ui): add viteplus as a package manager#2430

Closed
duowb wants to merge 3 commits intonpmx-dev:mainfrom
duowb:main
Closed

fix(ui): add viteplus as a package manager#2430
duowb wants to merge 3 commits intonpmx-dev:mainfrom
duowb:main

Conversation

@duowb
Copy link
Copy Markdown
Contributor

@duowb duowb commented Apr 9, 2026

🔗 Linked issue

resolves #2418

🧭 Context

Add viteplus as a package manager

📚 Description

add viteplus command

Since no Viteplus icon was found, the Vite icon was used instead.

@vercel
Copy link
Copy Markdown

vercel bot commented Apr 9, 2026

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
docs.npmx.dev Ready Ready Preview, Comment Apr 10, 2026 3:00am
npmx.dev (canary) Ready Ready Preview, Comment Apr 10, 2026 3:00am
1 Skipped Deployment
Project Deployment Actions Updated (UTC)
npmx-lunaria Ignored Ignored Apr 10, 2026 3:00am

Request Review

@github-actions
Copy link
Copy Markdown

github-actions bot commented Apr 9, 2026

Hello! Thank you for opening your first PR to npmx, @duowb! 🚀

Here’s what will happen next:

  1. Our GitHub bots will run to check your changes.
    If they spot any issues you will see some error messages on this PR.
    Don’t hesitate to ask any questions if you’re not sure what these mean!

  2. In a few minutes, you’ll be able to see a preview of your changes on Vercel

  3. One or more of our maintainers will take a look and may ask you to make changes.
    We try to be responsive, but don’t worry if this takes a few days.

@codecov
Copy link
Copy Markdown

codecov bot commented Apr 9, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ All tests successful. No failed tests found.

📢 Thoughts on this report? Let us know!

@coderabbitai
Copy link
Copy Markdown
Contributor

coderabbitai bot commented Apr 9, 2026

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: b9f7d051-5588-4fdb-8e92-d7076f8dd589

📥 Commits

Reviewing files that changed from the base of the PR and between 57687cc and 5b29e80.

📒 Files selected for processing (4)
  • app/components/Package/ManagerSelect.vue
  • app/components/Terminal/Execute.vue
  • app/components/Terminal/Install.vue
  • app/utils/install-command.ts

📝 Walkthrough

Walkthrough

Support for the vp (viteplus) package manager has been added to the application. The packageManagers constant in install-command.ts was extended to include a new entry with identifier vp, label vp, and associated command templates including vp exec, vp dlx, and vp create. Correspondingly, CSS selectors in the ManagerSelect, Execute, and Install Vue components were updated to display content for the vp variant when the data attribute data-pm is set to vp, enabling the package manager to appear and function within the component hierarchy.

🚥 Pre-merge checks | ✅ 3
✅ Passed checks (3 passed)
Check name Status Explanation
Description check ✅ Passed The pull request description clearly relates to the changeset, describing the addition of viteplus as a package manager with appropriate context and reasoning.
Linked Issues check ✅ Passed All code changes align with the objective to add viteplus as a package manager in the get-started widget, implementing the feature requested in issue #2418.
Out of Scope Changes check ✅ Passed All changes are directly related to adding viteplus support; no unrelated or out-of-scope modifications were introduced in this pull request.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@duowb duowb changed the title fix(ui): Add viteplus as a package manager fix(ui): add viteplus as a package manager Apr 9, 2026
Copy link
Copy Markdown
Contributor

@ghostdevv ghostdevv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for your PR!! For future could you create a branch on your fork for your PR (instead of using main), as it makes it easier for maintainers to review as we can make changes, and you if you want multiple PRs!

There are only two things that need updating:

  • In app/utils/prehydrate.ts I believe we need to do this

    Image
  • Can you update the tests in test/unit/app/utils/install-command.spec.ts

@ghostdevv
Copy link
Copy Markdown
Contributor

Did you mean to close this? @duowb

@ghostdevv
Copy link
Copy Markdown
Contributor

Did you mean to close this? @duowb

ah #2451

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add viteplus as a package manager

2 participants