feat(ui): support Vite+ vp package manager commands#2451
feat(ui): support Vite+ vp package manager commands#2451serhalp merged 3 commits intonpmx-dev:mainfrom
vp package manager commands#2451Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
2 Skipped Deployments
|
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
📝 WalkthroughWalkthroughThis pull request adds support for viteplus ( Suggested reviewers
🚥 Pre-merge checks | ✅ 3✅ Passed checks (3 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
🧹 Nitpick comments (1)
app/utils/prehydrate.ts (1)
24-24: Consider a small regression test for prehydrated'vp'selection.This allowlist is a key guard; a focused test that persists
"vp"and assertsdataset.pm === 'vp'would help prevent future drift.
ℹ️ Review info
⚙️ Run configuration
Configuration used: Organization UI
Review profile: CHILL
Plan: Pro
Run ID: 95e49d16-5312-4c35-89d4-f33075aa6571
📒 Files selected for processing (6)
app/components/Package/ManagerSelect.vueapp/components/Terminal/Execute.vueapp/components/Terminal/Install.vueapp/utils/install-command.tsapp/utils/prehydrate.tstest/unit/app/utils/install-command.spec.ts
| action: 'add', | ||
| executeLocal: 'vp exec', | ||
| executeRemote: 'vp dlx', | ||
| create: 'vp create', |
There was a problem hiding this comment.
vp package manager commands
|
Thanks for your first contribution, @duowb! 🙌 We'd love to welcome you to the npmx community. Come and say hi on Discord! And once you've joined, visit npmx.wamellow.com to claim the contributor role. |
🔗 Linked issue
resolves #2418
🧭 Context
Add viteplus as a package manager
📚 Description
add viteplus command
Thank you for your guidance. Please point out any shortcomings in the testing.