Skip to content

chore: manually add vite plus pre-commit hook#2434

Merged
ghostdevv merged 2 commits intonpmx-dev:mainfrom
alexdln:chore/precommit
Apr 9, 2026
Merged

chore: manually add vite plus pre-commit hook#2434
ghostdevv merged 2 commits intonpmx-dev:mainfrom
alexdln:chore/precommit

Conversation

@alexdln
Copy link
Copy Markdown
Member

@alexdln alexdln commented Apr 9, 2026

🧭 Context

Pre-commit doesn't work for now (or at least not for everyone). This file is created automatically in new versions of vite-plus, but unfortunately I couldn't update (#2433), so for now I'm just manually adding the hook

@vercel
Copy link
Copy Markdown

vercel bot commented Apr 9, 2026

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
npmx.dev Ready Ready Preview, Comment Apr 9, 2026 3:24pm
2 Skipped Deployments
Project Deployment Actions Updated (UTC)
docs.npmx.dev Ignored Ignored Preview Apr 9, 2026 3:24pm
npmx-lunaria Ignored Ignored Apr 9, 2026 3:24pm

Request Review

@codecov
Copy link
Copy Markdown

codecov bot commented Apr 9, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ All tests successful. No failed tests found.

📢 Thoughts on this report? Let us know!

@coderabbitai
Copy link
Copy Markdown
Contributor

coderabbitai bot commented Apr 9, 2026

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: db4e9d4c-a410-4c3a-beb5-a645931695dd

📥 Commits

Reviewing files that changed from the base of the PR and between d9e4bb4 and c671e00.

📒 Files selected for processing (1)
  • .vite-hooks/pre-commit
✅ Files skipped from review due to trivial changes (1)
  • .vite-hooks/pre-commit

📝 Walkthrough

Walkthrough

A new .vite-hooks/pre-commit file has been added to the repository. The file contains a single command, vp staged, and lacks a trailing newline at the end of the file. The change adds one line with no deletions.

Suggested reviewers

  • danielroe
  • wojtekmaj
🚥 Pre-merge checks | ✅ 1
✅ Passed checks (1 passed)
Check name Status Explanation
Description check ✅ Passed The pull request description clearly relates to the changeset by explaining the context and rationale for adding the pre-commit hook file.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

Copy link
Copy Markdown
Contributor

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 2


ℹ️ Review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: 7ee66ce2-7d1c-44fa-924f-2ca8a36a4bea

📥 Commits

Reviewing files that changed from the base of the PR and between 57687cc and d9e4bb4.

📒 Files selected for processing (1)
  • .vite-hooks/pre-commit

@ghostdevv ghostdevv changed the title chore: add pre-commit chore: manually add vite plus pre-commit hook Apr 9, 2026
@ghostdevv ghostdevv enabled auto-merge April 9, 2026 15:22
@ghostdevv ghostdevv added this pull request to the merge queue Apr 9, 2026
Merged via the queue into npmx-dev:main with commit 69cdfd4 Apr 9, 2026
22 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants