chore: upgrade vite-plus to 0.1.16#2436
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
2 Skipped Deployments
|
Disable vitest/require-mock-type-parameters lint rule introduced in the new version.
ec428f4 to
b7e7514
Compare
📝 WalkthroughWalkthroughThis pull request encompasses formatting improvements, a font stack reordering, and dependency version upgrades. The Possibly related PRs
Suggested reviewers
🚥 Pre-merge checks | ✅ 1✅ Passed checks (1 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
There was a problem hiding this comment.
🧹 Nitpick comments (1)
vite.config.ts (1)
48-48: Scope the Vitest rule disable to test files instead of global config.Line 48 disables
vitest/require-mock-type-parametersglobally. Since this rule applies only to vitest mock usage which is confined to test files, move the disable to a test-specific override to maintain type-safety checks elsewhere.Proposed config refactor
lint: { @@ rules: { - 'vitest/require-mock-type-parameters': 'off', 'no-console': 'warn', @@ overrides: [ + { + files: ['test/**/*.{test,spec}.ts'], + rules: { + 'vitest/require-mock-type-parameters': 'off', + }, + }, { files: [ 'server/**/*',
ℹ️ Review info
⚙️ Run configuration
Configuration used: Organization UI
Review profile: CHILL
Plan: Pro
Run ID: fdc48305-9b96-4e04-aaa6-624cf5ee4bcb
⛔ Files ignored due to path filters (1)
pnpm-lock.yamlis excluded by!**/pnpm-lock.yaml
📒 Files selected for processing (5)
lunaria/components.tslunaria/styles.tspackage.jsonpnpm-workspace.yamlvite.config.ts
No, I think we should keep it.
Cause by oxfmt change, this is expected behavior. |
ah! I thought npmx was using tabs which is why I was confused, but it's not |
|
Ah, I forgot about workspaces, thanks ❤️ |
🔗 Linked issue
#2433
🧭 Context
Fix pre-commit hook issues and includes Vite's security fixes.
📚 Description
Disable vitest/require-mock-type-parameters lint rule introduced in the new version.