Skip to content

chore: upgrade vite-plus to 0.1.16#2436

Merged
ghostdevv merged 2 commits intonpmx-dev:mainfrom
fengmk2:upgrade-vite-plus-0.1.16
Apr 9, 2026
Merged

chore: upgrade vite-plus to 0.1.16#2436
ghostdevv merged 2 commits intonpmx-dev:mainfrom
fengmk2:upgrade-vite-plus-0.1.16

Conversation

@fengmk2
Copy link
Copy Markdown
Contributor

@fengmk2 fengmk2 commented Apr 9, 2026

🔗 Linked issue

#2433

🧭 Context

Fix pre-commit hook issues and includes Vite's security fixes.

📚 Description

Disable vitest/require-mock-type-parameters lint rule introduced in the new version.

@vercel
Copy link
Copy Markdown

vercel bot commented Apr 9, 2026

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
npmx.dev Ready Ready Preview, Comment Apr 9, 2026 4:10pm
2 Skipped Deployments
Project Deployment Actions Updated (UTC)
docs.npmx.dev Ignored Ignored Preview Apr 9, 2026 4:10pm
npmx-lunaria Ignored Ignored Apr 9, 2026 4:10pm

Request Review

Disable vitest/require-mock-type-parameters lint rule introduced in the new version.
@fengmk2 fengmk2 force-pushed the upgrade-vite-plus-0.1.16 branch from ec428f4 to b7e7514 Compare April 9, 2026 15:45
@coderabbitai
Copy link
Copy Markdown
Contributor

coderabbitai bot commented Apr 9, 2026

📝 Walkthrough

Walkthrough

This pull request encompasses formatting improvements, a font stack reordering, and dependency version upgrades. The lunaria/components.ts file is reformatted with space-based indentation for template-literal HTML/SVG output. The lunaria/styles.ts file reorders the font fallback stack to place Apple Colour Emoji before Segoe UI Emoji. Dependencies are upgraded: vite-plus and related vitest packages are updated from version 0.1.12 to 0.1.16 across package.json and pnpm-workspace.yaml. Additionally, an ESLint rule is disabled in the Vite configuration.

Possibly related PRs

Suggested reviewers

  • danielroe
  • ghostdevv
🚥 Pre-merge checks | ✅ 1
✅ Passed checks (1 passed)
Check name Status Explanation
Description check ✅ Passed The pull request description clearly relates to the changeset, describing the upgrade of vite-plus to 0.1.16 and the disabling of a new lint rule.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@codecov
Copy link
Copy Markdown

codecov bot commented Apr 9, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ All tests successful. No failed tests found.

📢 Thoughts on this report? Let us know!

Copy link
Copy Markdown
Contributor

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🧹 Nitpick comments (1)
vite.config.ts (1)

48-48: Scope the Vitest rule disable to test files instead of global config.

Line 48 disables vitest/require-mock-type-parameters globally. Since this rule applies only to vitest mock usage which is confined to test files, move the disable to a test-specific override to maintain type-safety checks elsewhere.

Proposed config refactor
   lint: {
@@
     rules: {
-      'vitest/require-mock-type-parameters': 'off',
       'no-console': 'warn',
@@
     overrides: [
+      {
+        files: ['test/**/*.{test,spec}.ts'],
+        rules: {
+          'vitest/require-mock-type-parameters': 'off',
+        },
+      },
       {
         files: [
           'server/**/*',

ℹ️ Review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: fdc48305-9b96-4e04-aaa6-624cf5ee4bcb

📥 Commits

Reviewing files that changed from the base of the PR and between 69cdfd4 and b7e7514.

⛔ Files ignored due to path filters (1)
  • pnpm-lock.yaml is excluded by !**/pnpm-lock.yaml
📒 Files selected for processing (5)
  • lunaria/components.ts
  • lunaria/styles.ts
  • package.json
  • pnpm-workspace.yaml
  • vite.config.ts

Copy link
Copy Markdown
Contributor

@ghostdevv ghostdevv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we remove the hook added in #2434?

there are also formatting changes in the lunaria files, do you know why?

@fengmk2
Copy link
Copy Markdown
Contributor Author

fengmk2 commented Apr 9, 2026

Should we remove the hook added in #2434?

No, I think we should keep it.

there are also formatting changes in the lunaria files, do you know why?

Cause by oxfmt change, this is expected behavior.

@ghostdevv
Copy link
Copy Markdown
Contributor

Cause by oxfmt change, this is expected behavior.

ah! I thought npmx was using tabs which is why I was confused, but it's not

@alexdln
Copy link
Copy Markdown
Member

alexdln commented Apr 9, 2026

Ah, I forgot about workspaces, thanks ❤️

@ghostdevv ghostdevv added this pull request to the merge queue Apr 9, 2026
Merged via the queue into npmx-dev:main with commit 9222620 Apr 9, 2026
22 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants