chore: update knip config & prep for prod mode#771
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
2 Skipped Deployments
|
|
none of the dependencies in a nuxt project are actually used in prod so I tend to separate dev vs prod deps between lint/tooling stuff and the stuff required to actually build nuxt (which includes uno) |
|
Production mode isn't about dependencies actually being installed or imported at runtime. It's about what's imported from production source code (regardless of getting bundled or not). |
|
But yeah, some "faux production entries" are a result of that strategy, and that's fine from a Knip perspective, provided the |
b63adac to
db922a8
Compare
|
Rebased. Added a bunch of
|
|
more than happy to enable |
|
yeah it's just that we'd need both and run it twice I'll open a separate PR for that |
Not using production mode may hide issues, as this PR shows. At the same time, some consider it good to be strict in fast-pacing projects, and others only annoying. Let me know if you want me to add it to CI anyway.
package.json#scripts.postinstallno longer requires productiondependencies(simple-git-hooks, lint-staged), so it won't flag these in production modepnpm knip --productionto CI, but prepared for that:Removed unused exports@internalfor exports only imported by testsNo need to decide/fix now, as the changes don't affect how Knip is currently used in default/dev mode (but I'd be happy to if you agree!).