Skip to content

Comments

chore: knip config part 2: the resurgence#909

Merged
danielroe merged 2 commits intonpmx-dev:mainfrom
webpro:chore/knip-config-part-deux
Feb 4, 2026
Merged

chore: knip config part 2: the resurgence#909
danielroe merged 2 commits intonpmx-dev:mainfrom
webpro:chore/knip-config-part-deux

Conversation

@webpro
Copy link
Contributor

@webpro webpro commented Feb 4, 2026

@vercel
Copy link

vercel bot commented Feb 4, 2026

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
npmx.dev Ready Ready Preview, Comment Feb 4, 2026 8:12am
2 Skipped Deployments
Project Deployment Actions Updated (UTC)
docs.npmx.dev Ignored Ignored Preview Feb 4, 2026 8:12am
npmx-lunaria Ignored Ignored Feb 4, 2026 8:12am

Request Review

@codecov
Copy link

codecov bot commented Feb 4, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.

📢 Thoughts on this report? Let us know!

@webpro webpro marked this pull request as ready for review February 4, 2026 08:13
@webpro
Copy link
Contributor Author

webpro commented Feb 4, 2026

Sorry, can't seem to edit PR title

@coderabbitai
Copy link
Contributor

coderabbitai bot commented Feb 4, 2026

📝 Walkthrough

Walkthrough

This pull request modifies the continuous integration workflow and knip configuration. The CI workflow file now includes an additional step in the knip job to check for unused production code by running pnpm knip --production, complementing the existing unused code check. The knip configuration file is updated to refactor how test fixtures are excluded, moving the test/fixtures/** exclusion pattern directly into the project glob using a negated pattern instead of maintaining it as a separate ignore entry.

Possibly related PRs

Suggested reviewers

  • danielroe
🚥 Pre-merge checks | ✅ 1
✅ Passed checks (1 passed)
Check name Status Explanation
Description check ✅ Passed The PR description is related to the changeset, referencing a follow-up to a previous PR and documentation about knip configuration patterns that align with the changes made.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing touches
  • 📝 Generate docstrings
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment

Important

Action Needed: IP Allowlist Update

If your organization protects your Git platform with IP whitelisting, please add the new CodeRabbit IP address to your allowlist:

  • 136.113.208.247/32 (new)
  • 34.170.211.100/32
  • 35.222.179.152/32

Reviews will stop working after February 8, 2026 if the new IP is not added to your allowlist.


Comment @coderabbitai help to get the list of available commands and usage tips.

@danielroe danielroe changed the title Knip config part 2 chore: knip config part 2: the resurgence Feb 4, 2026
@danielroe danielroe added this pull request to the merge queue Feb 4, 2026
Merged via the queue into npmx-dev:main with commit 15f35f5 Feb 4, 2026
16 of 17 checks passed
@webpro webpro deleted the chore/knip-config-part-deux branch February 4, 2026 09:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants