Merged
Conversation
Fixed appending of classes to both <spacer> elements when size-sm & size-lg attributes are present.
…key` a variable, switch align and class for menu item
…into attributes Conflicts: lib/componentFactory.js
Allow contextual sizes for Spacer
…key` a variable, switch align and class for menu item
This would be useful if we are adding attributes that help us to integrate the HTML with some WYSIWYG (as Mailchimp with mc:edit). Most of the existing components already include the attributes, but not the button.
This should fix the test failing for a given spacer that might contain both arguments size (size-lg and size-sm) as we display twice the space with the helper class to show or display depends on the media queries.
Allow to add attributes to buttons and spacers
Remove data-parsed attributes from html output
The character   is being rendered as a space on Apple Mail's preview (tested on 9 and 10). Switching it to a regular seems to sort the issue. foundation#69 Fix foundation#69
… into marcandre-remove_useless_code
…space Switch <spacer>'s non-breaking spaces from   to
Closed
Author
|
Will run nugit-mailgenerator with this specific branch and see how it goes. Any problem we can quickly revert back to |
Author
|
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
10 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR #1 cause
to be wrongly converted (see issue here), this PR pulls in more upstream changes that includes the fix for this