1 request moving from pip to uv and add dev dependency#40
Conversation
|
#39 solved |
- add autoconter for numberd list - add uv to other parts too
…e-pre-commit-and-ruff WIP: add pre-commit config
| - id: ruff | ||
| types_or: [python, pyi] | ||
|
|
||
| args: | ||
| [ | ||
| --fix, | ||
| --exclude, | ||
| "contrib/*,Older Experiments/,backend/data/,scripts/", | ||
| ] | ||
| # Run the formatter. | ||
| - id: ruff-format | ||
| types_or: [python, pyi] | ||
| args: [--exclude, "contrib/*,Older Experiments/,backend/data/,scripts/"] |
There was a problem hiding this comment.
As mentioned during the MOSS call earlier consider merging this work with the .pre-commit-config.yml found under the Older Experiments directory so as to not lose the configuration we've used up until recently.
There was a problem hiding this comment.
I really appreciate the focus on linting and formatting! Just the same, the number of changes applied in this PR are massive as a result of applying what looks like linting and formatting updates. This makes it difficult to discern what was changed due to linting or formatting and what was changed to help with uv environment development. Consider decoupling these ideas into distinct PR's.
You could keep this PR in place, dropping the linting/formatting changes, and focus on just the uv implementation. Separately, another PR could be used for linting changes to help isolate those changes from environment management. This would improve our ability as developers to understand when something breaks or changes behavior which PR it was associated with and as a result, where to look for a root cause + resolution.
From my perspective, PR's should be small and isolated to one specific focus to help keep the development moving towards common goals and decrease the complexity for both the developers and reviewers (i.e. larger changes are harder to contextualize).
There was a problem hiding this comment.
Excited to see uv added to the project! Seeing this file added and the other environment files removed made me wonder: how do we know this will enable MOSS to work as we expect? We talked about this on the call today and I've added an issue to help describe what we might want to do prior to this PR being approved and merged. See #42 for more information.
|
|
||
| # UUID Generation (Needed for DiscoveryChain ID) - Standard library 'uuid' used. | ||
|
|
||
| # --- ADDED FOR PHASE 2 API --- |
There was a problem hiding this comment.
Consider retaining these comments within the pyproject.toml file, which allows for similar line-level comments.
|
To make improvement I need to make it clearer and smaller to manage. So, I close this PR and start with better approach |
tavallaie
deleted the
1-request---moving-from-pip-to-uv-and-add-dev-dependency
branch
|
Hey Ali, are you working on this? @vasilmax is also interested in implementing UV, and we don't want conflicting PRs/duplicated work. All yours if you're still planning to do this |
|
Max can take it. I can collaborate on his branch if needed. |
|
It is important to do it fast, and I am sick right now. It hard for me to do that. |
3 participants
Description
uvfrompip