forked from eyermt/moss
-
-
Notifications
You must be signed in to change notification settings - Fork 27
1 request moving from pip to uv and add dev dependency #40
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Closed
tavallaie
wants to merge
7
commits into
numfocus:main
from
tavallaie:1-request---moving-from-pip-to-uv-and-add-dev-dependency
Closed
Changes from all commits
Commits
Show all changes
7 commits
Select commit
Hold shift + click to select a range
6eae383
move to TOML and UV due to main repo #39 and this fork #1 and PEP 518
tavallaie ecaba89
chore: removing unnecessary file
tavallaie 04b8679
chore: update readme for using uv
tavallaie 5beb4f5
chore(README): fix and update
tavallaie be307f5
WIP: add pre-commit config
tavallaie 33700c2
Merge pull request #3 from tavallaie/2-request---adding-dev-tools-lik…
tavallaie aa1f585
disabaling ruff for contrib/,Older Experiments/,backend/data/,scripts/
tavallaie File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,19 @@ | ||
| repos: | ||
| - repo: https://github.com/astral-sh/ruff-pre-commit | ||
| # Ruff version. | ||
| rev: v0.11.9 | ||
| hooks: | ||
| # Run the linter. | ||
| - id: ruff | ||
| types_or: [python, pyi] | ||
|
|
||
| args: | ||
| [ | ||
| --fix, | ||
| --exclude, | ||
| "contrib/*,Older Experiments/,backend/data/,scripts/", | ||
| ] | ||
| # Run the formatter. | ||
| - id: ruff-format | ||
| types_or: [python, pyi] | ||
| args: [--exclude, "contrib/*,Older Experiments/,backend/data/,scripts/"] | ||
|
Comment on lines
+7
to
+19
Collaborator
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. As mentioned during the MOSS call earlier consider merging this work with the |
||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I really appreciate the focus on linting and formatting! Just the same, the number of changes applied in this PR are massive as a result of applying what looks like linting and formatting updates. This makes it difficult to discern what was changed due to linting or formatting and what was changed to help with
uvenvironment development. Consider decoupling these ideas into distinct PR's.You could keep this PR in place, dropping the linting/formatting changes, and focus on just the
uvimplementation. Separately, another PR could be used for linting changes to help isolate those changes from environment management. This would improve our ability as developers to understand when something breaks or changes behavior which PR it was associated with and as a result, where to look for a root cause + resolution.From my perspective, PR's should be small and isolated to one specific focus to help keep the development moving towards common goals and decrease the complexity for both the developers and reviewers (i.e. larger changes are harder to contextualize).