Dev Server Proxy wrong x-forwarded-port header value

[xelaris]

Since version v3.29.0 we are experiencing a problem in our dev setup, due to a wrong port being passed by the proxy in the x-forwarded-port header. Before 3.29 it was correctly set to 3000 (respectively the port the dev server is listening at). Since 3.29 it seems to be set to client port?

This seems to be related to #1051.

The previous implementation set the header like this:

    if (!proxyReq.hasHeader('x-forwarded-port')) {
      const localPort = req?.socket?.localPort
      if (localPort) {
        proxyReq.setHeader('x-forwarded-port', req.socket.localPort)
      }
    }

The new implementation does not seem to contain anything comparable.

Adding something like webRequest.headers.set('x-forwarded-port', req.socket.localPort); in

cli/packages/nuxi/src/dev/fetch.ts

Lines 283 to 284 in d436dfa

	const webRequest = new NodeRequest({ req, res })
	const webResponse = await fetchAddress(address, webRequest)

would probably fix this. I don't have enough insights though to solve it "the right way".

The x-forwarded-host header is affected in the same way.

[helman]

We are also experiencing this issue. We can confirm that it's caused by the minor version upgrade of @nuxt/cli from 3.28.0 to 3.29.2, which we discovered after rebuilding our package-lock.json.

We've found two temporary workarounds:

1. Run Nuxt commands with the --no-fork flag. This seems related to nuxt/cli#324.
2. Pin the @nuxt/cli dependency to version 3.28.0 in package.json.

A permanent fix for this would be greatly appreciated.

If this change is expected behaviour, it would be helpful to have it documented in the release notes.

[mattmess1221]

I think this issue has two parts.

1. Wrong x-forwarded headers. Easily fixed with a patch to insert them in fetchAddress() options.

2. Even when the correct headers are set, useRequestURL() is still wrong during dev without { xForwardedHost: true }.