refactor(dev): remove proxy server -> direct listening#1105
Merged
Conversation
commit: |
Contributor
📦 Bundle Size Comparison📉 nuxi
📉 nuxt-cli
➡️ create-nuxt
|
CodSpeed Performance ReportMerging #1105 will not alter performanceComparing Summary
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🔗 Linked issue
resolves #1098
resolves #1088
resolves #1081
resolves #965
resolves #209
resolves #1014
❓ Type of change
📚 Description
this drops the proxy server in favour of letting the nuxt dev server handle listening.
this will mean that there's not a persistent connection, but it avoids a lot of the pain and potential problematic behaviour with having a proxy (either over socket, which can be flaky on different oses/runtimes - or over network, which is slow on windows)
this also implements a fork pool for hard restarts