This repository was archived by the owner on Apr 6, 2023. It is now read-only.
fix(vite): use externality to handle vite-node externals#6153
Merged
Conversation
✅ Deploy Preview for nuxt3-docs ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
pi0
approved these changes
Jul 26, 2022
Member
pi0
left a comment
pi0
left a comment
There was a problem hiding this comment.
LGTM. It would be nice if later refactor isExternal utility since is almost repeated in dev-bundler
pi0
changed the title
externality to handle externalsexternality to handle vite-node externals
7 tasks
Merged
7 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🔗 Linked issue
nuxt/nuxt#13994
❓ Type of change
📚 Description
This reuses the externalization options from
dev-bundlerto make the behaviour more consistent.📝 Checklist