fix(vite): respect ctx.nuxt.options.modulesDir for resolving externals with vite-node

[pi0]

🔗 Linked issue

resolves nuxt/nuxt#14952, nuxt/nuxt#14907, nuxt/nuxt#14802, nuxt/nuxt#14928

❓ Type of change

• 📖 Documentation (updates to the documentation or readme)
• 🐞 Bug fix (a non-breaking change that fixes an issue)
• 👌 Enhancement (improving an existing functionality like performance)
• ✨ New feature (a non-breaking change that adds functionality)
• ⚠️ Breaking change (fix or feature that would cause existing functionality to change)

📚 Description

We are overriding shouldExternalize (PR: #6153) of vite-node, and use mlly resolver to directly resolve paths. Issue with nuxt/nuxt#14952 happens because directly setting URL to the directory of rootDir, causes resolving from parent node_modules and finally different resolved vue version. (Correct way is setting rootDir + '/_node_modules' or rootDir + /index.mjs)

This PR resolves issue by respecting modulesDir for resolving vue and other dependencies. In the future we might come of with better implementation to actually reuse same vite resolution. I didn't use return id on external branch (while it works!) until getting confirmation from @antfu. Vite-node's default external handler however does this. src

Also worth to mention that isExternal('vue') resolves to null as it is unable to determine external status.

📝 Checklist

• I have linked an issue or discussion.
• I have updated the documentation accordingly.

[netlify]

✅ Deploy Preview for nuxt3-docs canceled.

Name	Link
🔨 Latest commit	de1aa4e
🔍 Latest deploy log	https://app.netlify.com/sites/nuxt3-docs/deploys/6324f491ff8ba60008ef15e6

[pi0]

@antfu Shall we do this to be same as vite-node? Would it diretly require vue or let vite resolve to fullpath?

Suggested change

	return resolveModule(result.id, { url: ctx.nuxt.options.modulesDir })
	return id

[antfu]

The id passed here should already be resolved by Vite. So yes I think we could directly do this.

[pi0]

Thanks for checking. FYI, it is not always resolved. You can reproduce it only with an external repository by putting a debugger. vue for instance is directly passed to shouldExternalize.

[pi0]

Merging as hotfix.