Skip to content

Basic np.load implementation, falling back to NumPy #1126

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
manopapad merged 4 commits into from
Feb 28, 2024
Merged

Basic np.load implementation, falling back to NumPy #1126

manopapad merged 4 commits into from
Feb 28, 2024

Conversation

@manopapad
Copy link
Contributor

@manopapad manopapad commented Feb 21, 2024

Mostly there to ensure that the NumPy ndarray coming out of np.load gets cast to a cuNumeric ndarray. As requested by ORNL.

@manopapad
Basic np.load implementation, falling back to NumPy
3c9cdcc 
Mostly there to ensure that the NumPy ndarray coming out of np.load
gets cast to a cuNumeric ndarray. As requested by ORNL.
@manopapad manopapad added the category:new-feature PR introduces a new feature and will be classified as such in release notes label Feb 21, 2024
@manopapad manopapad requested a review from bryevdv February 21, 2024 01:05
@marcinz marcinz changed the base branch from branch-24.01 to branch-24.03 February 22, 2024 01:02
bryevdv
bryevdv requested changes Feb 23, 2024
View reviewed changes
Copy link
Contributor

@bryevdv bryevdv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Probably needs docs in light of other PRs

@manopapad
Copy link
Contributor Author

manopapad commented Feb 27, 2024

I made a new io.rst and added load, but I'm getting an error when trying to build the docs locally:

/home/mpapadakis/a/cunumeric/docs/cunumeric/source/api/io.rst:document isn't included in any toctree

Any idea what I did wrong?

@bryevdv
Copy link
Contributor

bryevdv commented Feb 27, 2024 •
edited
Loading

Need to add io to the TOC in routines.rst as well

@manopapad manopapad merged commit 35b2649 into nv-legate:branch-24.03 Feb 28, 2024
@manopapad manopapad deleted the mp/2024-02-20/np.load branch February 28, 2024 01:16
manopapad pushed a commit that referenced this pull request Feb 18, 2025
@bryevdv
Recent ports from public repo (#146)
30fd2c0 
* add np.digitize (ref: #1117)

* add np.diff (ref: #636)

* add np.load (ref: #1126)

* add cov (ref: #1129)

* add average (ref: #1124)

* add logical reductions (ref: #1123)

* fix docstring syntax

* review comments

* fix import

* fix error from update

* fix copy pasta
marcinz pushed a commit to marcinz/cunumeric that referenced this pull request Nov 5, 2025
@XiaLuNV
Update test_concatenate_stack.py (nv-legate#1126)
14c768d 
* Update test_concatenate_stack.py
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@bryevdv bryevdv bryevdv approved these changes

Assignees

No one assigned

Labels

category:new-feature PR introduces a new feature and will be classified as such in release notes

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@manopapad @bryevdv