Adding cov() functionality with tests #1129
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…om numpy's cov() implementation Signed-off-by: Joseph Guman <joeytg@stanford.edu>
Contributor
manopapad
added
the
category:new-feature
Contributor
|
/ok to test |
22 tasks
Author
|
@manopapad Sorry, I had forgotten to merge my branch with branch-24.03 before making the pull request. I made the update and believe it should be ready for a round of testing. |
Contributor
|
/ok to test |
manopapad
reviewed
Mar 5, 2024
Co-authored-by: Manolis Papadakis <manopapad@gmail.com>
Co-authored-by: Manolis Papadakis <manopapad@gmail.com>
Co-authored-by: Manolis Papadakis <manopapad@gmail.com>
Co-authored-by: Manolis Papadakis <manopapad@gmail.com>
Co-authored-by: Manolis Papadakis <manopapad@gmail.com>
Co-authored-by: Manolis Papadakis <manopapad@gmail.com>
Contributor
|
Let me know when you're ready to let CI run the tests again. I need to reiterate the magic words "/ok to test" every time ... |
…oseph Guman <joeytg@stanford.edu>
for more information, see https://pre-commit.ci
Author
|
@manopapad I think everything should be good now. If there's anything I missed, I'll fix it immediately and will be going to make all the corrections to average() as well. |
Contributor
|
/ok to test |
manopapad
approved these changes
Mar 8, 2024
Contributor
manopapad
left a comment
manopapad
left a comment
There was a problem hiding this comment.
Looks good. I made a miniscule change (using clip instead of amax, to avoid an intermediate array), will just wait for CI to pass.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fitting numpy's cov() implementation into cunumeric's framework