Add a pool of region managers with LRU eviction #392
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
magnatelee
added
the
category:improvement
manopapad
reviewed
Sep 29, 2022
Comment on lines
+1249
to
+1254
| lru_managers: Deque[RegionManager] = deque() | ||
| for to_check in self.lru_managers: | ||
| if to_check is not region_mgr: | ||
| lru_managers.append(to_check) | ||
| assert len(lru_managers) < len(self.lru_managers) | ||
| self.lru_managers = lru_managers |
Contributor
There was a problem hiding this comment.
Out of curiosity, did this not work?
self.lru_managers.remove(region_mgr)
Contributor
Author
There was a problem hiding this comment.
that would have worked. (the original code this was copied from needed a loop, but then it has become unnecessary after the code went through some simplification.) will make a follow-on PR to clean this up after the release.
manopapad
pushed a commit
that referenced
this pull request
Mar 5, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
One side effect of PR #364 is that it eagerly collects region managers even when their fields can be reused immediately after their active field counts become zero. This makes the code create many fresh regions, most of which aren't necessary if the code was able to reuse managers with no active fields. This is problematic as the runtime doesn't perform region destruction as frequently as those fresh regions are created, which ends up limiting how far the runtime can run ahead.
To solve this problem, this PR introduces a pool of inactive region managers with some simple LRU eviction policy.