Better store management #364
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
magnatelee
added
the
category:improvement
bryevdv
reviewed
Sep 19, 2022
Contributor
Author
|
@bryevdv thanks for the review. I think I addressed all of your comments, but let me know if I missed any or you happened to have more. |
bryevdv
approved these changes
Sep 20, 2022
Contributor
|
LGTM! |
and allow unbound stores to have alignment constraints
This was referenced Sep 28, 2022
manopapad
added a commit
that referenced
this pull request
Mar 5, 2025
* Fix error message on missing OpenMP support * Update src/core/runtime/detail/runtime.cc Co-authored-by: Jacob Faibussowitsch <jacob.fai@gmail.com> --------- Co-authored-by: Jacob Faibussowitsch <jacob.fai@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR contains changes to eagerly collect stores that are unused throughout the execution. The PR also makes two small improvements for better field reuse: 1) allowing fields to be reused for any stores with the same size; 2) allowing the region field of a temporary store to be "moved" to another store within the same operation. Finally, the PR also eliminates costly consensus matches for single node execution.