Adjust consensus match frequency based on field sizes #402
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
magnatelee
added
the
category:improvement
manopapad
approved these changes
Sep 30, 2022
magnatelee
added a commit
to magnatelee/legate.core
that referenced
this pull request
Sep 30, 2022
* Perform consensus match more frequently for bigger free fields * Minor cleanup
magnatelee
added a commit
that referenced
this pull request
Sep 30, 2022
manopapad
added a commit
that referenced
this pull request
Oct 25, 2022
* Add script to generate conda envs * remove gcc and sysroot pkgs * split out openmpi and compilers options * Adjust consensus match frequency based on field sizes (#402) * Perform consensus match more frequently for bigger free fields * Minor cleanup * add command line args for selection * help wording * Make script executable * Fixes for python 3.8 * Remove old environment files * Unify file naming for "compilers" and "openmpi" * Fix typo * Remove optional ninja dependency * Not just for the core, include cunumeric also * Update build documentation * Fix a file link * Fix formatting * remove typing_extensions dependency * remove jinja dependency * slight vertical whitespace improvemetn * Use custom BooleanFlag action, for the benefit of py3.8 * Update build instructions * Fix intra-document reference * Revise file naming scheme * Update BUILD.md Co-authored-by: Wonchan Lee <wonchanl@nvidia.com> Co-authored-by: Manolis Papadakis <mpapadakis@nvidia.com> Co-authored-by: Manolis Papadakis <manopapad@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR #364 accidentally removed the heuristic that issues consensus matches more frequently for bigger fields. This PR recovers that heuristic in the form of match credits: Each field manager is now assigned a credit based on its size. Whenever a new free field arrives at the field manager, it adds its credit to the match manager's counter. When the counter exceeds a threshold, the match manager issues a consensus match.