Skip to content

Conversation

@loppear
Copy link
Contributor

@loppear loppear commented Oct 23, 2019

Here's a first stab at optionally combining all includeScript scripts into a single webpack bundle.

Things noted in initial testing on 100mhl:

  • app.js is 2.2M, vs individual page-targeted bundles of 0.7-1.5M. (Not unreasonable, as a visit to two parts of the site is already a savings, but worth digging in more as I wouldn't have expected the dependency trees of non-shared components to be so big.)
  • throwing some ignorable errors for some admin scripts that are now included on the frontend but I think are using renderContext scripts directly rather than includeScripts for external deps (datatables). So external (non-bundled) deps are doing to have to be considered here.
  • there's some bug TBD with the non-singleBundle behavior here on the particular chart implementation there.

So I think this is usable to test whether a single bundle works for other projects, but not yet ready to merge.

@loppear loppear requested a review from alexjreich October 23, 2019 00:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants