Skip to content

singleBundle config for one app.js #32

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
loppear wants to merge 2 commits into
base: master
Choose a base branch
from
Open

singleBundle config for one app.js #32

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
6c777a0
singleBundle config option
loppear Oct 22, 2019
de8003c
Default webpack mode to 'production'
loppear Oct 23, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
23 changes: 20 additions & 3 deletions src/index.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -119,6 +119,8 @@ class ClientJS extends NxusModule {
this._fromConfigBundles(app)

this._builders = []
this._singleBundleScripts = []
this._singleBundleName = 'app.js'
this.readyToBuild = new Promise((resolve, reject) => {
app.on('launch', () => {
resolve()
Expand All @@ -141,6 +143,7 @@ class ClientJS extends NxusModule {
assetFolder: '.tmp/clientjs',
webcomponentsURL: '/js/webcomponentsjs/webcomponents-lite.min.js',
entries: {},
singleBundle: false,
sourceMap: app.config.NODE_ENV != 'production' ? 'cheap-module-eval-source-map' : false,
buildSeries: false,
buildOnly: false,
Expand All @@ -165,6 +168,11 @@ class ClientJS extends NxusModule {
if (this.config.buildNone) return
let op = this.config.buildSeries ? Promise.mapSeries : Promise.map
return op(this._builders, (x) => {return x()})
.then(() => {
if (this._singleBundleScripts.length > 0) {
return this._bundle(this._singleBundleScripts, this._singleBundleName)
}
})
}

/**
Expand All @@ -189,7 +197,8 @@ class ClientJS extends NxusModule {
]
}

let scripts = [path.join(this.config.routePrefix,outputPath)]
let scripts = [path.join(this.config.routePrefix,
(this.config.singleBundle ? this._singleBundleName : outputPath))]

templater.on('renderContext.'+templateName, () => {
return {
Expand Down Expand Up @@ -242,12 +251,12 @@ class ClientJS extends NxusModule {
}

var options = {
entry: path.resolve(entry),
entry: _.isArray(entry) ? _.uniq(entry.map(e => path.resolve(e))) : path.resolve(entry),
output: {
filename: outputFilename,
path: outputPath
},
mode: app.config.NODE_ENV,
mode: app.config.NODE_ENV || 'production',
plugins: [
new OnlyIfChangedPlugin({
cacheDirectory: path.join(opts.rootDir, '.tmp/cache'),
Expand Down Expand Up @@ -335,6 +344,14 @@ class ClientJS extends NxusModule {
* @param {[type]} output the output path to use in the browser to access the bundled source
*/
bundle(entry, output) {
if (this.config.singleBundle) {
this._singleBundleScripts.push(entry)
} else {
return this._bundle(entry, output)
}
}

_bundle(entry, output) {
this.log.debug('Bundling', entry, "to", output)

let outputDir = path.dirname(output)
Expand Down