Skip to content

Feat/dev watch task improvement#585

Merged
marcinkrasowski merged 2 commits intomainfrom
feat/dev-watch-task-improvement
Jan 27, 2026
Merged

Feat/dev watch task improvement#585
marcinkrasowski merged 2 commits intomainfrom
feat/dev-watch-task-improvement

Conversation

@marcinkrasowski
Copy link
Copy Markdown
Collaborator

@marcinkrasowski marcinkrasowski commented Jan 26, 2026

What does this PR do?

  • updated dependencies, scripts, and turbo configurations
  • update README files to reflect deprecation of npm run dev and introduce watch scripts

Summary by CodeRabbit

  • Documentation

    • Updated development workflow documentation to recommend using separate watch:deps and watch:apps scripts instead of a single dev command.
    • Enhanced getting started guides with clearer instructions for monorepo-level setup and managing local dependencies.
  • Chores

    • Deprecated npm run dev; will be removed in a future release.

✏️ Tip: You can customize this high-level summary in your review settings.

- Removed redundant tasks and scripts in turbo.json and package.json.
- Added and aligned missing blocks and dependencies across apps.
- Adjusted `dev` and build workflows for improved caching and output handling.
…ev` and introduce `watch` scripts

- Replaced `npm run dev` references with `npm run watch:deps` and `npm run watch:apps`.
- Added detailed notes and instructions for new development workflows.
- Improved clarity on running individual apps and handling dependencies in monorepo setup.
@coderabbitai
Copy link
Copy Markdown
Contributor

coderabbitai Bot commented Jan 26, 2026

Walkthrough

The PR reorganizes the monorepo development workflow by splitting the single npm run dev command into two separate watch scripts: npm run watch:deps (monitoring dependencies) and npm run watch:apps (monitoring applications). Documentation and turbo configurations are updated accordingly, with deprecation messaging for the legacy workflow.

Changes

Cohort / File(s) Summary
Root-level workflow reorganization
package.json, turbo.json
New watch:apps and watch:deps scripts introduced; dev script now includes app-specific filter (-F={./apps/*}). Turbo.json now defines dev task with caching disabled, full logging, and persistence, alongside updates to build, lint, test, format, and start tasks for output logging configuration.
Frontend app configuration
apps/frontend/turbo.json, apps/frontend/package.json, apps/frontend/README.md
Removed dev and build tasks from turbo.json. Frontend package.json dependency block list restructured with additions of bento-grid, cta-section, document-list, feature-section*, hero-section, media-section, pricing-section. Updated README with root-level watch instructions and local dev notes.
API Harmonization app configuration
apps/api-harmonization/turbo.json, apps/api-harmonization/package.json, apps/api-harmonization/README.md
Removed entire dev task configuration from turbo.json. Dev script modified to include --exec "node --watch" executor. Added block dependencies matching frontend changes. Updated README with monorepo-aware watch script guidance.
Documentation updates
README.md, apps/docs/docs/getting-started/running-locally.md, apps/docs/docs/main-components/frontend-app/storybook.md
Updated getting-started guide to emphasize new two-script workflow with deprecation notice for npm run dev. Storybook documentation augmented with watch script alternatives.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~12 minutes

Possibly related PRs

  • feat: dev task optimization to reduce CPU/RAM load #419: Refactors the dev workflow by replacing turbo dev with turbo watch dev, adding separate watch scripts, and modifying turbo.json configurations — directly overlaps with this PR's script and configuration reorganization.

Poem

🐰 Hop, hop! The scripts split in two,
Watch your deps, watch your apps too!
No more tangled dev commands to chase,
Just two clear paths through monorepo space! 🚀

🚥 Pre-merge checks | ✅ 2 | ❌ 1
❌ Failed checks (1 warning)
Check name Status Explanation Resolution
Description check ⚠️ Warning The description covers what the PR does and mentions key changes, but omits required sections: Related Ticket, detailed explanation of how changes address issues, side effects analysis, and testing instructions. Add Related Ticket reference, explain how changes improve the workflow, describe any side effects (e.g., breaking changes to existing scripts), and provide detailed testing steps.
✅ Passed checks (2 passed)
Check name Status Explanation
Title check ✅ Passed The title clearly summarizes the main change: improving the dev watch task workflow by splitting it into separate watch:deps and watch:apps scripts.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

Copy link
Copy Markdown
Contributor

@coderabbitai coderabbitai Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

🤖 Fix all issues with AI agents
In `@apps/api-harmonization/package.json`:
- Line 13: The dev script in package.json currently nests a redundant watcher by
using nest start --watch together with --exec "node --watch"; remove the --exec
"node --watch" fragment so the script uses only "nest start --watch
--preserveWatchOutput" (or alternatively replace with a two-step approach using
"nest build --watch" + "node --watch dist/main.js" if you need Node's native
watcher), updating the "dev" npm script value accordingly.
🧹 Nitpick comments (1)
apps/frontend/package.json (1)

18-53: Minor formatting inconsistency: double spaces before version specifier.

The block dependencies have inconsistent spacing (e.g., "@o2s/blocks.article": "*" with two spaces) compared to other dependencies in this file (line 54 onward) and in apps/api-harmonization/package.json which use single spaces.

Consider running your formatter to normalize the whitespace.

Comment thread apps/api-harmonization/package.json
@marcinkrasowski marcinkrasowski merged commit d769bf1 into main Jan 27, 2026
10 checks passed
@marcinkrasowski marcinkrasowski deleted the feat/dev-watch-task-improvement branch January 27, 2026 08:28
@coderabbitai coderabbitai Bot mentioned this pull request Mar 11, 2026
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant