Skip to content

[PR #38] p3: fork test comment references non-existent issue #22.x — broken tracker reference #133

@obchain

Description

@obchain

Summary

test_executeLiquidation_endToEndOnFork in Section E contains:

/// Status: SKIPPED pending issue #22.x

and later:

/// TODO(#22.x): unmocked PCS swap once a stable pair + amount is identified.

No issue #22 exists in the obchain/Charon tracker. The PR itself closes #23. The sub-issue notation "#22.x" is not a valid GitHub issue reference format. This creates a permanently broken tracker reference embedded in source code that:

  1. Cannot be auto-closed by GitHub
  2. Points developers to a non-existent issue when they try to un-skip the test
  3. Makes it unclear which milestone or issue actually gates the fork test

Location

contracts/test/CharonLiquidator.t.soltest_executeLiquidation_endToEndOnFork NatSpec comment

Fix

Replace #22.x with the correct issue number that tracks fork test completion (likely the issue that supersedes #123, or a new dedicated issue). Update both the Status: line and the TODO line.

Refs #38

Metadata

Metadata

Assignees

No one assigned

    Labels

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions