Summary
test_executeLiquidation_endToEndOnFork in Section E contains:
/// Status: SKIPPED pending issue #22.x
and later:
/// TODO(#22.x): unmocked PCS swap once a stable pair + amount is identified.
No issue #22 exists in the obchain/Charon tracker. The PR itself closes #23. The sub-issue notation "#22.x" is not a valid GitHub issue reference format. This creates a permanently broken tracker reference embedded in source code that:
- Cannot be auto-closed by GitHub
- Points developers to a non-existent issue when they try to un-skip the test
- Makes it unclear which milestone or issue actually gates the fork test
Location
contracts/test/CharonLiquidator.t.sol — test_executeLiquidation_endToEndOnFork NatSpec comment
Fix
Replace #22.x with the correct issue number that tracks fork test completion (likely the issue that supersedes #123, or a new dedicated issue). Update both the Status: line and the TODO line.
Refs #38
Summary
test_executeLiquidation_endToEndOnForkin Section E contains:and later:
No issue #22 exists in the obchain/Charon tracker. The PR itself closes #23. The sub-issue notation "#22.x" is not a valid GitHub issue reference format. This creates a permanently broken tracker reference embedded in source code that:
Location
contracts/test/CharonLiquidator.t.sol—test_executeLiquidation_endToEndOnForkNatSpec commentFix
Replace
#22.xwith the correct issue number that tracks fork test completion (likely the issue that supersedes #123, or a new dedicated issue). Update both theStatus:line and theTODOline.Refs #38