delaunay + voronoi#917
Merged
Merged
Conversation
Member
Author
Contributor
|
In the case of Delaunay, I can see how it is useful to connect points by group; I've tried to implement it in #925. However I can't really figure a use case for doing this with Voronoi (except to be consistent? Being consistent is a good thing.). I'm curious also how you plan to use pointerEvents, probably with titles? Should we add titles in the penguinCulmenVoronoi test? A nit: commit e8ddf63 should probably be separated from this PR since it affects all marks. |
* delaunay updates: - group by z or stroke for delaunayLink - group by z or stroke for delaunayMesh * a few fixes * no group by stroke for delaunayLink Co-authored-by: Mike Bostock <mbostock@gmail.com>
6d0dc10 to
67bfac4
Compare
Fil
approved these changes
Jun 9, 2022
Contributor
There was a problem hiding this comment.
🎉
Suggestions:
- add an image of Delaunay + hull?(test/output/penguinCulmenDelaunaySpecies.svg demonstrates it well).
- default pointerEvents to "auto" (equivalent to "visiblePainted", but more well-known?)
#928 tracks a few follow-ups that I have in mind.
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Fixes #812. TODO: