Correct version guard for dune formatting change

[nojb]

The formatting change introduced in #10892 was guarded under version 3.18 in #11175 to avoid breaking existing users of the unversioned dune format-dune-file (see #10892 (comment)). However, its replacement action (format-dune-file) introduced #11166 will only appear in 3.18, so the format change should in fact be guarded under version 3.19 to give users time to adapt.

[Leonidas-from-XIV]

Sounds fair enough, especially as it would be nice to release 3.18 soon-ish. Can you promote the failures?

[nojb]

Sounds fair enough, especially as it would be nice to release 3.18 soon-ish. Can you promote the failures?

I promoted some of the failures, but I cannot reproduce the rest in my machine. Can you help me by pushing the corrected test files to this branch? Thanks!

[Leonidas-from-XIV]

I was confused about this as well as it worked for me too. But the issue was that I had too old of a ppxlib in my dev-switch so I've created #11488.

[nojb]

I was confused about this as well as it worked for me too. But the issue was that I had too old of a ppxlib in my dev-switch so I've created #11488.

Thanks, now almost everything passes. However there's still one failure that looks unrelated. Do you confirm?

[Leonidas-from-XIV]

Yes, the Dynlink failure happens (more than) occasionally but is unrelated.

[nojb]

Thanks for the confirmation!