Skip to content

Require minimal ppxlib version#11488

Merged
nojb merged 2 commits intoocaml:mainfrom
Leonidas-from-XIV:ppxlib-min-version
Feb 18, 2025
Merged

Require minimal ppxlib version#11488
nojb merged 2 commits intoocaml:mainfrom
Leonidas-from-XIV:ppxlib-min-version

Conversation

@Leonidas-from-XIV
Copy link
Copy Markdown
Collaborator

Otherwise the describe test is failing because the description does not match.

Similar reasoning as #11487.

Otherwise the describe test is failing because the description does not
match.

Similar reasoning as ocaml#11487.

Signed-off-by: Marek Kubica <marek@tarides.com>
@Leonidas-from-XIV Leonidas-from-XIV added the chore Something that just needs to be done. label Feb 18, 2025
Copy link
Copy Markdown
Collaborator

@nojb nojb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Copy Markdown
Collaborator

@nojb nojb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@nojb nojb merged commit 1ef56ff into ocaml:main Feb 18, 2025
anmonteiro pushed a commit to anmonteiro/dune that referenced this pull request Apr 22, 2025
Otherwise the describe test is failing because the description does not
match.

Similar reasoning as ocaml#11487.

Signed-off-by: Marek Kubica <marek@tarides.com>
Co-authored-by: Nicolás Ojeda Bär <n.oje.bar@gmail.com>
Sudha247 pushed a commit to Sudha247/dune that referenced this pull request Jul 23, 2025
Otherwise the describe test is failing because the description does not
match.

Similar reasoning as ocaml#11487.

Signed-off-by: Marek Kubica <marek@tarides.com>
Co-authored-by: Nicolás Ojeda Bär <n.oje.bar@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

chore Something that just needs to be done.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants