fix(pkg): make autolock solver env same as pkg lock#12719
Conversation
|
I thought it would be better if the solve done by autolocking would only solve for the current platform since that would be faster, and ensure the build plan would work on the current platform. Does this PR change it to solve for the default platforms as well as the current platform or just the default platforms? |
|
@gridbugs It's the same as |
|
Maybe before doing this or any other change in this regard we should figure out what we want autolocking to do. @Alizter mentioned some options in #11868 (comment) and I think some of the proposals (including my current favorite, so I am a bit biased) suggest that autolocking should indeed just lock for the current system. |
|
I would argue that this change should have been made in #12694. I'm not arguing that the behaviour introduced here is correct for autolocking, but it unbreaks some invariants I was hoping to preserve until I refactored the autolocking code. |
0d86274 to
642f17a
Compare
Signed-off-by: Ali Caglayan <alizter@gmail.com>
642f17a to
bcb2a40
Compare
Follow up to #12694. I've reverted the changes to autolocking by adding some more copy and pasted code and keeping the two implementations in sync.
This means we are solving for multiple platforms for autolocking, but lock dirs here are an implementation detail and this inefficiency can be removed in a future change.
We are still not settled on the question of default target platforms yet so no point making any decisions here.
A full cleanup of all dupes will follow this PR soon.