boot: remove csexp and pp from external libs#12735
Merged
Alizter merged 1 commit intoocaml:mainfrom Nov 18, 2025
Merged
Conversation
Sudha247
reviewed
Nov 17, 2025
Sudha247
approved these changes
Nov 17, 2025
Collaborator
|
Could you rebase, please? I think this is ready to merge. |
Alizter
force-pushed
the
push-zvwnnrmwvyus
branch
from
3e55386 to
4d6c734
Compare
This appeared to have snuck in at some point. We track these libraries, along with re, spawn and uutf in both duneboot.ml and bootstrap_info.ml. They are the vendored libraries we use for bootstrap but not for building the other libraries. Signed-off-by: Ali Caglayan <alizter@gmail.com>
Alizter
force-pushed
the
push-zvwnnrmwvyus
branch
from
4d6c734 to
6c2cec1
Compare
Member
|
Isn't this commit empty? |
Collaborator
Author
|
@rgrinberg Yes, that's my mistake. I rebased on top of #12719 which also accidentally fixed this. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This appears to have snuck in at
some point#12623.We track these libraries, along with re, spawn and uutf in both duneboot.ml and bootstrap_info.ml. They are the vendored libraries we use for bootstrap but not for building the other libraries.