Skip to content

Conversation

@MisterDA
Copy link
Contributor

These log sources add a lot of noise when debugging. The networking interface has been stable for some time now, and I want to be able by default to debug using logging messages the worker and obuilder, so I need some kind of filtering.
Is this the most efficient / cleanest way to do it?

@MisterDA MisterDA requested a review from tmcgilchrist January 23, 2023 09:00
@talex5
Copy link
Contributor

talex5 commented Jan 23, 2023

Is this the most efficient / cleanest way to do it?

Prometheus_unix.Logging.init already takes a ?levels argument that lets you control the levels individually.

It would be good to have a command-line option to let the user choose at runtime. I see you already have an issue for that already - dbuenzli/logs#37

@MisterDA
Copy link
Contributor Author

Prometheus_unix.Logging.init already takes a ?levels argument that lets you control the levels individually.

Much better, thanks!

It would be good to have a command-line option to let the user choose at runtime. I see you already have an issue for that already

Oh right, I forgot about this one! I'll try writing a patch.

@MisterDA MisterDA removed the request for review from tmcgilchrist January 23, 2023 10:48
@MisterDA MisterDA merged commit 32bb98b into master Feb 10, 2023
@MisterDA MisterDA deleted the silent-logging branch February 10, 2023 10:09
MisterDA added a commit to MisterDA/opam-repository that referenced this pull request Mar 2, 2023
…uster (0.2.1)

CHANGES:

- Expose the ocluster-worker library in the ocluster-worker package
  (@MisterDA @art-w, ocurrent/ocluster#219 ocurrent/ocluster#217 ocurrent/ocluster#151, reviewed by @tmcgilchrist)
- Remove corrupted repositories from the cache (@kit-ty-kate ocurrent/ocluster#216, reviewed by @talex5)
- Allow workers to report additional prometheus metrics (@patricoferris ocurrent/ocluster#210, reviewed by @tmcgilchrist, @MisterDA)
- Smother Cap'n Proto and TLS debug logs (@MisterDA ocurrent/ocluster#213, reviewed by @talex5)
- Added command line option to set obuilder health check period (@mtelvers ocurrent/ocluster#214, reviewed by @tmcgilchrist)
- Conditionally compile macos user_temp fetcher (@tmcgilchrist ocurrent/ocluster#209, reviewed by @MisterDA, @mtelvers)
- Make rsync-mode mandatory when using rsync store (@tmcgilchrist ocurrent/ocluster#202, reviewed by @MisterDA)
- Windows service bugfixes (@MisterDA ocurrent/ocluster#200, reviewed by @tmcgilchrist)
- Fix build and opam metadata (@MisterDA @tmcgilchrist ocurrent/ocluster#199 ocurrent/ocluster#203)
MisterDA added a commit to MisterDA/opam-repository that referenced this pull request Mar 3, 2023
…uster (0.2.1)

CHANGES:

- Expose the ocluster-worker library in the ocluster-worker package
  (@MisterDA @art-w, ocurrent/ocluster#219 ocurrent/ocluster#217 ocurrent/ocluster#151, reviewed by @tmcgilchrist)
- Remove corrupted repositories from the cache (@kit-ty-kate ocurrent/ocluster#216, reviewed by @talex5)
- Allow workers to report additional prometheus metrics (@patricoferris ocurrent/ocluster#210, reviewed by @tmcgilchrist, @MisterDA)
- Smother Cap'n Proto and TLS debug logs (@MisterDA ocurrent/ocluster#213, reviewed by @talex5)
- Added command line option to set obuilder health check period (@mtelvers ocurrent/ocluster#214, reviewed by @tmcgilchrist)
- Conditionally compile macos user_temp fetcher (@tmcgilchrist ocurrent/ocluster#209, reviewed by @MisterDA, @mtelvers)
- Make rsync-mode mandatory when using rsync store (@tmcgilchrist ocurrent/ocluster#202, reviewed by @MisterDA)
- Windows service bugfixes (@MisterDA ocurrent/ocluster#200, reviewed by @tmcgilchrist)
- Fix build and opam metadata (@MisterDA @tmcgilchrist ocurrent/ocluster#199 ocurrent/ocluster#203)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants