Added command line option to set obuilder health check period #214
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tmcgilchrist
approved these changes
Feb 8, 2023
MisterDA
added a commit
to ocurrent/docker-base-images
that referenced
this pull request
Feb 9, 2023
- ocaml-dockerfile
+ Build and install opam master from source in Windows images.
(@MisterDA ocurrent/ocaml-dockerfile#140)
+ Include the ocaml-beta-repository in the images.
(@kit-ty-kate ocurrent/ocaml-dockerfile#132, review by @MisterDA)
- ocluster
+ Custom healthcheck period. (@mtelvers ocurrent/ocluster#214)
MisterDA
added a commit
to ocurrent/docker-base-images
that referenced
this pull request
Feb 10, 2023
- ocaml-dockerfile
+ Build and install opam master from source in Windows images.
(@MisterDA ocurrent/ocaml-dockerfile#140)
+ Include the ocaml-beta-repository in the images.
(@kit-ty-kate ocurrent/ocaml-dockerfile#132, review by @MisterDA)
- ocluster
+ Custom healthcheck period. (@mtelvers ocurrent/ocluster#214)
+ Allow workers to report additional prometheus metrics. (@patricoferris ocurrent/ocluster#210)
+ other minor things.
MisterDA
added a commit
to ocurrent/docker-base-images
that referenced
this pull request
Feb 10, 2023
- ocaml-dockerfile
+ Build and install opam master from source in Windows images.
(@MisterDA ocurrent/ocaml-dockerfile#140)
+ Include the ocaml-beta-repository in the images.
(@kit-ty-kate ocurrent/ocaml-dockerfile#132, review by @MisterDA)
- ocluster
+ Custom healthcheck period. (@mtelvers ocurrent/ocluster#214)
+ Allow workers to report additional prometheus metrics. (@patricoferris ocurrent/ocluster#210)
+ other minor things.
- ocaml-version
+ Expose 4.08.1 and 4.14.1 (@MisterDA ocurrent/ocaml-version#60)
MisterDA
added a commit
to ocurrent/docker-base-images
that referenced
this pull request
Feb 13, 2023
- ocaml-dockerfile
+ Build and install opam master from source in Windows images.
(@MisterDA ocurrent/ocaml-dockerfile#140 ocurrent/ocaml-dockerfile#142)
+ Include the ocaml-beta-repository in the images.
(@kit-ty-kate ocurrent/ocaml-dockerfile#132, review by @MisterDA)
- ocluster
+ Custom healthcheck period. (@mtelvers ocurrent/ocluster#214)
+ Allow workers to report additional prometheus metrics. (@patricoferris ocurrent/ocluster#210)
+ other minor things.
- ocaml-version
+ Expose 4.08.1 and 4.14.1 (@MisterDA ocurrent/ocaml-version#60)
fixup
MisterDA
added a commit
to MisterDA/opam-repository
that referenced
this pull request
Mar 2, 2023
…uster (0.2.1) CHANGES: - Expose the ocluster-worker library in the ocluster-worker package (@MisterDA @art-w, ocurrent/ocluster#219 ocurrent/ocluster#217 ocurrent/ocluster#151, reviewed by @tmcgilchrist) - Remove corrupted repositories from the cache (@kit-ty-kate ocurrent/ocluster#216, reviewed by @talex5) - Allow workers to report additional prometheus metrics (@patricoferris ocurrent/ocluster#210, reviewed by @tmcgilchrist, @MisterDA) - Smother Cap'n Proto and TLS debug logs (@MisterDA ocurrent/ocluster#213, reviewed by @talex5) - Added command line option to set obuilder health check period (@mtelvers ocurrent/ocluster#214, reviewed by @tmcgilchrist) - Conditionally compile macos user_temp fetcher (@tmcgilchrist ocurrent/ocluster#209, reviewed by @MisterDA, @mtelvers) - Make rsync-mode mandatory when using rsync store (@tmcgilchrist ocurrent/ocluster#202, reviewed by @MisterDA) - Windows service bugfixes (@MisterDA ocurrent/ocluster#200, reviewed by @tmcgilchrist) - Fix build and opam metadata (@MisterDA @tmcgilchrist ocurrent/ocluster#199 ocurrent/ocluster#203)
MisterDA
added a commit
to MisterDA/opam-repository
that referenced
this pull request
Mar 3, 2023
…uster (0.2.1) CHANGES: - Expose the ocluster-worker library in the ocluster-worker package (@MisterDA @art-w, ocurrent/ocluster#219 ocurrent/ocluster#217 ocurrent/ocluster#151, reviewed by @tmcgilchrist) - Remove corrupted repositories from the cache (@kit-ty-kate ocurrent/ocluster#216, reviewed by @talex5) - Allow workers to report additional prometheus metrics (@patricoferris ocurrent/ocluster#210, reviewed by @tmcgilchrist, @MisterDA) - Smother Cap'n Proto and TLS debug logs (@MisterDA ocurrent/ocluster#213, reviewed by @talex5) - Added command line option to set obuilder health check period (@mtelvers ocurrent/ocluster#214, reviewed by @tmcgilchrist) - Conditionally compile macos user_temp fetcher (@tmcgilchrist ocurrent/ocluster#209, reviewed by @MisterDA, @mtelvers) - Make rsync-mode mandatory when using rsync store (@tmcgilchrist ocurrent/ocluster#202, reviewed by @MisterDA) - Windows service bugfixes (@MisterDA ocurrent/ocluster#200, reviewed by @tmcgilchrist) - Fix build and opam metadata (@MisterDA @tmcgilchrist ocurrent/ocluster#199 ocurrent/ocluster#203)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For macOS workers, 10 minutes effectively means that the health check runs after every job. This PR adds a command line option to increase the interval or stop it altogether.
I used the Cmdliner to get the default value of 600 seconds:
Arg.opt Arg.float 600.0. However, it may be preferable to useArg.opt Arg.(some float) Noneand remove theoptionin the initialisation steps of therunfunction inworker/cluster_worker.ml.